From: Salah Triki <salah.triki@gmail.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] fs: befs: check flags field to validate the superblock state
Date: Tue, 9 Aug 2016 13:59:52 +0100 [thread overview]
Message-ID: <20160809125952.GA17353@pc> (raw)
In-Reply-To: <cf8fccd9-849a-68c5-17fa-1102cb288b50@osg.samsung.com>
On Tue, Aug 09, 2016 at 01:40:25PM +0100, Luis de Bethencourt wrote:
> On 09/08/16 13:32, Salah Triki wrote:
> > flags field records the superblock state, so check if it is equal to
> > BEFS_DIRTY.
> >
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
> > fs/befs/super.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/befs/super.c b/fs/befs/super.c
> > index 5ab75e8..79be409 100644
> > --- a/fs/befs/super.c
> > +++ b/fs/befs/super.c
> > @@ -103,7 +103,7 @@ befs_check_sb(struct super_block *sb)
> > return BEFS_ERR;
> > }
> >
> > - if (befs_sb->log_start != befs_sb->log_end) {
> > + if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) {
> > befs_error(sb, "Filesystem not clean! There are blocks in the "
> > "journal. You must boot into BeOS and mount this volume "
> > "to make it clean.");
> >
>
> Hi Salah,
>
> Looks like a good idea. Any reason why commit 1/2, where you add the flag, and commit
> 2/2, where you read it, are split and not in the same commit? Curious.
>
> Will test it soon.
>
> Thanks :)
> Luis
Hi Luis,
I split the two commits for sake of clarity. But now I realize that it
is not usefull at all.
Will send a corrected patch soon.
Thanx
Salah
next prev parent reply other threads:[~2016-08-09 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 12:32 [PATCH 1/3] fs: befs: load flags field from disk Salah Triki
2016-08-09 12:32 ` [PATCH 2/3] fs: befs: check flags field to validate the superblock state Salah Triki
2016-08-09 12:40 ` Luis de Bethencourt
2016-08-09 12:59 ` Salah Triki [this message]
2016-08-09 13:50 ` Luis de Bethencourt
2016-08-09 12:32 ` [PATCH 3/3] fs: befs: fix typo in befs_sb_info Salah Triki
2016-08-09 12:46 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809125952.GA17353@pc \
--to=salah.triki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.