All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: rkrcmar@redhat.com
Cc: famz@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com,
	mst@redhat.com, peterx@redhat.com, jan.kiszka@web.de,
	pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH for-2.7 0/2] intel-iommu: restrict EIM to quirkless KVM
Date: Tue, 9 Aug 2016 08:31:52 -0700 (PDT)	[thread overview]
Message-ID: <20160809153149.131721.2006@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <20160809150333.9991-1-rkrcmar@redhat.com>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 20160809150333.9991-1-rkrcmar@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH for-2.7 0/2] intel-iommu: restrict EIM to quirkless KVM

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e018fb0 intel-iommu: restrict EIM to quirkless KVM
5ef6f2f linux-headers: update to v4.8-rc1

=== OUTPUT BEGIN ===
Checking PATCH 1/2: linux-headers: update to v4.8-rc1...
ERROR: code indent should never use tabs
#32: FILE: linux-headers/linux/kvm.h:885:
+^Iunion {$

ERROR: code indent should never use tabs
#33: FILE: linux-headers/linux/kvm.h:886:
+^I^I__u32 pad;$

ERROR: code indent should never use tabs
#34: FILE: linux-headers/linux/kvm.h:887:
+^I^I__u32 devid;$

ERROR: code indent should never use tabs
#35: FILE: linux-headers/linux/kvm.h:888:
+^I};$

ERROR: code indent should never use tabs
#43: FILE: linux-headers/linux/kvm.h:1034:
+#define KVM_MSI_VALID_DEVID^I(1U << 0)$

ERROR: code indent should never use tabs
#50: FILE: linux-headers/linux/kvm.h:1040:
+^I__u32 devid;$

ERROR: code indent should never use tabs
#51: FILE: linux-headers/linux/kvm.h:1041:
+^I__u8  pad[12];$

ERROR: code indent should never use tabs
#59: FILE: linux-headers/linux/kvm.h:1086:
+^IKVM_DEV_TYPE_ARM_VGIC_ITS,$

ERROR: code indent should never use tabs
#60: FILE: linux-headers/linux/kvm.h:1087:
+#define KVM_DEV_TYPE_ARM_VGIC_ITS^IKVM_DEV_TYPE_ARM_VGIC_ITS$

total: 9 errors, 0 warnings, 51 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: intel-iommu: restrict EIM to quirkless KVM...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  parent reply	other threads:[~2016-08-09 15:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09 15:03 [Qemu-devel] [PATCH for-2.7 0/2] intel-iommu: restrict EIM to quirkless KVM Radim Krčmář
2016-08-09 15:03 ` [Qemu-devel] [PATCH 1/2] linux-headers: update to v4.8-rc1 Radim Krčmář
2016-08-09 16:11   ` Radim Krčmář
2016-08-09 15:03 ` [Qemu-devel] [PATCH 2/2] intel-iommu: restrict EIM to quirkless KVM Radim Krčmář
2016-08-10  3:29   ` Peter Xu
2016-08-10 16:59     ` Radim Krčmář
2016-08-11  3:33       ` Peter Xu
2016-08-09 15:31 ` no-reply [this message]
2016-08-09 16:07   ` [Qemu-devel] [PATCH] checkpatch: allow tabs in linux-headers Radim Krčmář
2016-08-09 16:14     ` Paolo Bonzini
2016-08-09 16:37       ` Radim Krčmář
2016-08-09 16:39         ` Paolo Bonzini
2016-08-09 16:57           ` Radim Krčmář
2016-08-10  7:09       ` Cornelia Huck
2016-08-10 13:55         ` Radim Krčmář
2016-08-10 14:01           ` Cornelia Huck
2016-08-09 17:32     ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160809153149.131721.2006@ex-std-node742.prod.rhcloud.com \
    --to=no-reply@patchew.org \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.