From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Easwar Hariharan
<easwar.hariharan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] IB/hfi1: Fetch monitor values on-demand for CableInfo query
Date: Tue, 9 Aug 2016 20:58:01 +0300 [thread overview]
Message-ID: <20160809175801.GD23921@leon.nu> (raw)
In-Reply-To: <1470755838-14117-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Tue, Aug 09, 2016 at 11:17:18AM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> From: Easwar Hariharan <easwar.hariharan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> The monitor values from bytes 22 through 81 of the QSFP memory space
> (SFF 8636) are dynamic and serving them out of the QSFP memory cache
> maintained by the driver provides stale data to the CableInfo SMA query.
> This patch refreshes the dynamic values from the QSFP memory on request
> and overwrites the stale data from the cache for the overlap between the
> requested range and the monitor range.
>
>
Ira,
On all your patches, you have double line between commit message and
tags.
> Reviewed-by: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Easwar Hariharan <easwar.hariharan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-09 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 15:17 [PATCH] IB/hfi1: Fetch monitor values on-demand for CableInfo query ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1470755838-14117-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-09 17:58 ` Leon Romanovsky [this message]
[not found] ` <20160809175801.GD23921-2ukJVAZIZ/Y@public.gmane.org>
2016-08-10 5:35 ` ira.weiny
[not found] ` <20160810053549.GA32695-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-08-10 5:51 ` Leon Romanovsky
[not found] ` <20160810055138.GH23921-2ukJVAZIZ/Y@public.gmane.org>
2016-08-10 19:07 ` Dalessandro, Dennis
[not found] ` <1470856029.9289.11.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-11 5:07 ` Leon Romanovsky
2016-08-10 10:19 ` Leon Romanovsky
2016-08-22 18:22 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809175801.GD23921@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=easwar.hariharan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.