From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXCW1-0004lJ-Kp for qemu-devel@nongnu.org; Tue, 09 Aug 2016 15:16:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXCW0-00064K-II for qemu-devel@nongnu.org; Tue, 09 Aug 2016 15:16:41 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:46017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXCW0-00061a-Cm for qemu-devel@nongnu.org; Tue, 09 Aug 2016 15:16:40 -0400 Date: Tue, 9 Aug 2016 21:16:28 +0200 From: Aurelien Jarno Message-ID: <20160809191628.GA1206@aurel32.net> References: <20160809190229.27871-1-bobby.prani@gmail.com> <20160809190229.27871-2-bobby.prani@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160809190229.27871-2-bobby.prani@gmail.com> Subject: Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pranith Kumar Cc: Peter Maydell , "open list:All patches CC here" , pbonzini@redhat.com On 2016-08-09 15:02, Pranith Kumar wrote: > Change the flag type to 'int' to fix the implicit conversion error. > > Suggested-by: Peter Maydell > Signed-off-by: Pranith Kumar > --- > fpu/softfloat-specialize.h | 2 +- > include/fpu/softfloat.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h > index 43d0890..46b4091 100644 > --- a/fpu/softfloat-specialize.h > +++ b/fpu/softfloat-specialize.h > @@ -197,7 +197,7 @@ float128 float128_default_nan(float_status *status) > | should be simply `float_exception_flags |= flags;'. > *----------------------------------------------------------------------------*/ > > -void float_raise(int8_t flags, float_status *status) > +void float_raise(int flags, float_status *status) > { > status->float_exception_flags |= flags; > } > diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h > index 0e57ee5..416cf7a 100644 > --- a/include/fpu/softfloat.h > +++ b/include/fpu/softfloat.h > @@ -196,9 +196,9 @@ enum { > }; > > typedef struct float_status { > + int float_exception_flags; > signed char float_detect_tininess; > signed char float_rounding_mode; > - signed char float_exception_flags; > signed char floatx80_rounding_precision; > /* should denormalised results go to zero and set the inexact flag? */ > flag flush_to_zero; This changes the size of the structure, and thus of the CPU*State structures. I don't think it's something we want to do, especially given we currently only use 7 flags, so 7 bits and that fits in a char. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net