All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libtasn1: add upstream build fix patch
Date: Tue, 9 Aug 2016 23:06:42 +0200	[thread overview]
Message-ID: <20160809230642.21436629@free-electrons.com> (raw)
In-Reply-To: <1470775776-18685-1-git-send-email-gustavo@zacarias.com.ar>

Hello,

On Tue,  9 Aug 2016 17:49:36 -0300, Gustavo Zacarias wrote:
> Under certain circumstances the build will fail because some warnings
> are treated as errors, such as:
> 
> ./parser_aux.h:97:1: error: inlining failed in call to '_asn1_set_down':
> call is unlikely and code size would grow [-Werror=inline]
> ASN1.y:437:59: error: called from here [-Werror=inline]
> cc1: all warnings being treated as errors
> 
> Add upstream patch to address this.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

After discussing on IRC, this patch is not needed: the current version
of libtasn1, 4.8, has the gcc-warnings option disabled by default, so
it does not add -Werror.

Apparently, the problem starts with version 4.9, which Gustavo was
about to submit as a security fix. In this case --disable-gcc-warnings
should be used.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-08-09 21:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09 20:49 [Buildroot] [PATCH] libtasn1: add upstream build fix patch Gustavo Zacarias
2016-08-09 21:06 ` Thomas Petazzoni [this message]
2016-08-09 21:14   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160809230642.21436629@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.