From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bXJ1h-0005gJ-8n
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 22:13:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bXJ1c-0003N7-Ug
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 22:13:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50718)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bXJ1c-0003Mz-MD
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 22:13:44 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id EEB4D81254
	for <qemu-devel@nongnu.org>; Wed, 10 Aug 2016 02:13:43 +0000 (UTC)
Date: Wed, 10 Aug 2016 10:06:41 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160810020641.GF11351@al.usersys.redhat.com>
References: <1470757664-25161-1-git-send-email-pbonzini@redhat.com>
	<1470757664-25161-2-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470757664-25161-2-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] checkpatch: tweak the files in which
 TABs are checked
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, thuth@redhat.com, armbru@redhat.com

On Tue, 08/09 17:47, Paolo Bonzini wrote:
> Include Python and shell scripts, and make an exception for Perl
> scripts we imported from Linux or elsewhere.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/checkpatch.pl | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b7cb4ab..7ccf6a8 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1351,8 +1351,10 @@ sub process {
>  			WARN("adding a line without newline at end of file\n" . $herecurr);
>  		}
>  
> -# check we are in a valid source file C or perl if not then ignore this hunk
> -		next if ($realfile !~ /\.(h|c|cpp|pl)$/);
> +# check we are in a valid source file; if not then tabs are allowed.
> +# make an exception from some scripts imported from other projects.

s/from some/for some/ ?

> +		next if ($realfile !~ /\.(h|c|cpp|pl|py|sh)$/);
> +		next if ($realfile =~ /(checkpatch|get_maintainer|texi2pod)\.pl$/);
>  
>  # in QEMU, no tabs are allowed
>  		if ($rawline =~ /^\+.*\t/) {
> -- 
> 2.7.4
> 
> 
>