From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PULL 2/2] docker: Add "--enable-werror" to configure command line
Date: Wed, 10 Aug 2016 10:15:44 +0800 [thread overview]
Message-ID: <20160810021544.GH11351@al.usersys.redhat.com> (raw)
In-Reply-To: <66317136-7ead-e3ba-ad3b-e295ced14164@redhat.com>
On Tue, 08/09 17:21, Paolo Bonzini wrote:
>
>
> On 05/08/2016 11:04, Fam Zheng wrote:
> > We don't have .git in the docker checkout, add this to enable -Werror
> > explicitly.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > Message-id: 1469453510-658-1-git-send-email-famz@redhat.com
> > ---
> > tests/docker/common.rc | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> > index 77069e1..0c6d8d5 100755
> > --- a/tests/docker/common.rc
> > +++ b/tests/docker/common.rc
> > @@ -24,6 +24,7 @@ requires()
> > build_qemu()
> > {
> > $QEMU_SRC/configure \
> > + --enable-werror \
> > ${TARGET_LIST:+"--target-list=${TARGET_LIST}"} \
> > --prefix="$PWD/install" \
> > $EXTRA_CONFIGURE_OPTS \
> >
>
> centos6 has -Wuninitialized errors. Should this be applied only to
> Fedora and Ubuntu?
That way I think build_qemu can be made sensible to the env. For now I'm not
seeing any compiling failure with centos6, even though this patch is already
merged. Do you mean this is a potential false alarm?
Fam
next prev parent reply other threads:[~2016-08-10 2:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 9:04 [Qemu-devel] [PULL 0/2] Docker patches Fam Zheng
2016-08-05 9:04 ` [Qemu-devel] [PULL 1/2] docker: Be compatible with older docker Fam Zheng
2016-08-05 9:04 ` [Qemu-devel] [PULL 2/2] docker: Add "--enable-werror" to configure command line Fam Zheng
2016-08-09 15:21 ` Paolo Bonzini
2016-08-10 2:15 ` Fam Zheng [this message]
2016-08-10 7:09 ` Paolo Bonzini
2016-08-10 7:41 ` Fam Zheng
2016-08-05 10:44 ` [Qemu-devel] [PULL 0/2] Docker patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810021544.GH11351@al.usersys.redhat.com \
--to=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.