From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Andy Gross <agross@codeaurora.org>,
Stephen Boyd <stephen.boyd@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host"
Date: Tue, 9 Aug 2016 21:09:37 -0700 [thread overview]
Message-ID: <20160810040937.GF26240@tuxbot> (raw)
In-Reply-To: <1470695643-32169-1-git-send-email-john.stultz@linaro.org>
On Mon 08 Aug 15:34 PDT 2016, John Stultz wrote:
Changes in this file is commonly prefixed "ARM: dts: apq8064:", please
follow that. Perhaps:
ARM: dts: apq8064: Drop dr_mode property from usb phy
> Most 8064 devices have micro-usb ports for phy1, so setting
> the dr_mode to host here seems incorrect.
>
> Leaving it unspecified should default to otg, and then
> any boards that wish to specify something else, can
> override it in their dts file.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Andy Gross <agross@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Stephen Boyd <stephen.boyd@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 9dc83b0..7e43416 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -750,7 +750,6 @@
> reg = <0x12500000 0x400>;
> interrupts = <GIC_SPI 100 IRQ_TYPE_NONE>;
> status = "disabled";
> - dr_mode = "host";
>
> clocks = <&gcc USB_HS1_XCVR_CLK>,
> <&gcc USB_HS1_H_CLK>;
> --
> 1.9.1
>
prev parent reply other threads:[~2016-08-10 4:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 22:34 [PATCH 1/2] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host" John Stultz
2016-08-08 22:34 ` John Stultz
2016-08-08 22:34 ` [PATCH 2/2] device-tree: nexus7: Add IMEM syscon and reboot reason support John Stultz
2016-08-10 4:28 ` Bjorn Andersson
2016-08-10 5:04 ` John Stultz
[not found] ` <CALAqxLWWDQVyMVEP5kB2h0ig0WuX8Vq8TmO_Gd+Yaesa1k3qwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-10 5:27 ` Bjorn Andersson
2016-08-10 5:27 ` Bjorn Andersson
2016-08-10 4:09 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810040937.GF26240@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.