From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935080AbcHJUQG (ORCPT ); Wed, 10 Aug 2016 16:16:06 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35789 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932622AbcHJUQD (ORCPT ); Wed, 10 Aug 2016 16:16:03 -0400 Date: Wed, 10 Aug 2016 12:58:58 +0200 From: Ingo Molnar To: kan.liang@intel.com Cc: peterz@infradead.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, ak@linux.intel.com, eranian@google.com Subject: Re: [PATCH V3 2/2] perf/x86/intel/uncore: add enable_box for client msr uncore Message-ID: <20160810105858.GA29633@gmail.com> References: <1467208912-8179-1-git-send-email-kan.liang@intel.com> <1467208912-8179-2-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467208912-8179-2-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * kan.liang@intel.com wrote: > From: Kan Liang > > PERF_GLOBAL_CTL could be cleared after Package C7. This patch tries to > workaround this issue by re-enable PERF_GLOBAL_CTL in enable_box. > The workaround does not cover all cases. It helps for new events after > returning from C7. > There is no drawback in letting the thing enabled, so it does not need > disable_box here. This changelog is very poor for similar reasons as: Re: [PATCH] perf/x86/intel/uncore: correct uncore num_counters Please fix the changelog to conform to the standard changelog style: - first describe the symptoms of the bug - how does a user notice? - then describe how the code behaves today and how that is causing the bug - and then only describe how it's fixed. The first item is the most important one - while developers (naturally) tend to concentrate on the least important point, the last one. Thanks, Ingo