From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf intel-pt: Fix ip compression
Date: Wed, 10 Aug 2016 10:05:15 -0300 [thread overview]
Message-ID: <20160810130515.GE4249@kernel.org> (raw)
In-Reply-To: <4cc98408-bf55-439a-e88b-15f1ca57b0ff@intel.com>
Em Wed, Aug 10, 2016 at 11:32:21AM +0300, Adrian Hunter escreveu:
> On 20/07/16 12:00, Adrian Hunter wrote:
> > June 2015 Intel SDM introduced IP Compression types 4 and 6. Refer section
> > 36.4.2.2 Target IP (TIP) Packet - IP Compression.
> > Existing Intel PT packet decoder did not support type 4, and got type 6
> > wrong. Because type 3 and type 4 have the same number of bytes, the packet
> > 'count' has been changed from being the number of ip bytes to being the
> > type code. That allows the Intel PT decoder to correctly decide whether to
> > sign-extend or use the last ip. However that also meant the code had to be
> > adjusted in a number of places.
> >
> > Currently hardware is not using the new compression types, so this fix has
> > no effect on existing hardware.
> >
> > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> > ---
> > .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 44 +++++++++++-----------
> > .../util/intel-pt-decoder/intel-pt-pkt-decoder.c | 24 ++++++++----
> > 2 files changed, 40 insertions(+), 28 deletions(-)
> Hi
> This is outstanding but still applies.
Oops, will get that merged, sorry for the delay.
- Arnaldo
next prev parent reply other threads:[~2016-08-10 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 9:00 [PATCH] perf intel-pt: Fix ip compression Adrian Hunter
2016-08-10 8:32 ` Adrian Hunter
2016-08-10 13:05 ` Arnaldo Carvalho de Melo [this message]
2016-08-16 18:13 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810130515.GE4249@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.