All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Jacob Stiffler <j-stiffler@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] ti-tisdk-makefile: pru-icss: fix syntax error
Date: Wed, 10 Aug 2016 12:02:41 -0400	[thread overview]
Message-ID: <20160810160241.GQ18333@edge> (raw)
In-Reply-To: <1470842688-26360-1-git-send-email-j-stiffler@ti.com>

Jake,

It's not visible from the patch what the syntax error is:

> -	for i in 0 1; \
> +	for i in 0 1; \

-- 
Denys


On Wed, Aug 10, 2016 at 11:24:48AM -0400, Jacob Stiffler wrote:
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
>  .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_pru-icss           | 6 +++---
>  .../recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb        | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_pru-icss b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_pru-icss
> index 7dbbca7..02f81bf 100644
> --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_pru-icss
> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_pru-icss
> @@ -40,9 +40,9 @@ pru-icss_install_none:
>  
>  pru-icss_install_am335x: pru-icss_install_common
>  	@cd example-applications; cd `find . -name "*pru-icss*"`; \
> -	for i in 0 1; \
>  	install -m 0644 ./examples/am335x/PRU_Halt/gen/PRU_Halt.out \
>  		$(DESTDIR)/lib/firmware/pru; \
> +	for i in 0 1; \
>  	do \
>  		install -m 0644 ./examples/am335x/PRU_RPMsg_Echo_Interrupt$${i}/gen/PRU_RPMsg_Echo_Interrupt$${i}.out \
>  			$(DESTDIR)/lib/firmware/pru; \
> @@ -50,9 +50,9 @@ pru-icss_install_am335x: pru-icss_install_common
>  
>  pru-icss_install_am437x: pru-icss_install_common
>  	@cd example-applications; cd `find . -name "*pru-icss*"`; \
> -	for i in 0 1; \
>  	install -m 0644 ./examples/am437x/PRU_Halt/gen/PRU_Halt.out \
>  		$(DESTDIR)/lib/firmware/pru; \
> +	for i in 0 1; \
>  	do \
>  		install -m 0644 ./examples/am437x/PRU_RPMsg_Echo_Interrupt$${i}/gen/PRU_RPMsg_Echo_Interrupt$${i}.out \
>  			$(DESTDIR)/lib/firmware/pru; \
> @@ -60,9 +60,9 @@ pru-icss_install_am437x: pru-icss_install_common
>  
>  pru-icss_install_am572x: pru-icss_install_common
>  	@cd example-applications; cd `find . -name "*pru-icss*"`; \
> -	for i in 1 2; \
>  	install -m 0644 ./examples/am572x/PRU_Halt/gen/PRU_Halt.out \
>  		$(DESTDIR)/lib/firmware/pru; \
> +	for i in 1 2; \
>  	do \
>  		for j in 0 1; \
>  		do \
> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
> index 75f40d2..6118a99 100644
> --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
> @@ -48,7 +48,7 @@ SRC_URI = "\
>      file://Makefile_linalg-examples \
>  "
>  
> -PR = "r73"
> +PR = "r74"
>  
>  MAKEFILES_MATRIX_GUI = "matrix-gui-browser \
>                          refresh-screen \
> -- 
> 2.7.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


      reply	other threads:[~2016-08-10 16:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 15:24 [PATCH] ti-tisdk-makefile: pru-icss: fix syntax error Jacob Stiffler
2016-08-10 16:02 ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810160241.GQ18333@edge \
    --to=denys@ti.com \
    --cc=j-stiffler@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.