From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:37740 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932407AbcHJTJR (ORCPT ); Wed, 10 Aug 2016 15:09:17 -0400 Date: Wed, 10 Aug 2016 15:09:16 -0400 From: "J. Bruce Fields" To: Linus Torvalds Cc: Josef Bacik , kernel test robot , Al Viro , Chris Mason , David Sterba , LKML , LKP , linux-btrfs , Linux NFS Mailing List Subject: Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda] Message-ID: <20160810190915.GA22411@pad> References: <20160810053947.GG21941@yexl-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, Aug 10, 2016 at 11:56:15AM -0700, Linus Torvalds wrote: > On Wed, Aug 10, 2016 at 11:46 AM, Josef Bacik wrote: > > > > So my naive fix would be something like this > > Bruce? Josef's patch looks ObviouslyCorrect(tm) to me now that I look > at it - all the other callers of fh_compose() also seem to just drop > the dentry unconditionally, knowing that fh_compose() took a ref to it > if needed. > > In fact, the only thing I'd do differently would be to not even put > the comment there at all, since this call site isn't any different > from any of the others. If anything, it could go on fh_compose() if we > want to add comments. Yep, makes sense to me too. OK with me if you want to take it, otherwise I'll run it through my usual tests and send you a pull request probably today or tomorrow. Thanks, Josef! (And kernel test robot folks--the speed with which they're catching stuff, and bisecting down to individual commits, is really amazing to me.) --b. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2690737214802049111==" MIME-Version: 1.0 From: J. Bruce Fields To: lkp@lists.01.org Subject: Re: [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f, n=0a} still in use (1) [unmount of btrfs vda] Date: Wed, 10 Aug 2016 15:09:16 -0400 Message-ID: <20160810190915.GA22411@pad> In-Reply-To: List-Id: --===============2690737214802049111== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Aug 10, 2016 at 11:56:15AM -0700, Linus Torvalds wrote: > On Wed, Aug 10, 2016 at 11:46 AM, Josef Bacik wrote: > > > > So my naive fix would be something like this > = > Bruce? Josef's patch looks ObviouslyCorrect(tm) to me now that I look > at it - all the other callers of fh_compose() also seem to just drop > the dentry unconditionally, knowing that fh_compose() took a ref to it > if needed. > = > In fact, the only thing I'd do differently would be to not even put > the comment there at all, since this call site isn't any different > from any of the others. If anything, it could go on fh_compose() if we > want to add comments. Yep, makes sense to me too. OK with me if you want to take it, otherwise I'll run it through my usual tests and send you a pull request probably today or tomorrow. Thanks, Josef! (And kernel test robot folks--the speed with which they're catching stuff, and bisecting down to individual commits, is really amazing to me.) --b. --===============2690737214802049111==--