From: "Jörn Engel" <joern@purestorage.com>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: David Miller <davem@davemloft.net>,
dingtianhong@huawei.com, zyjzyj2000@gmail.com,
andy@greyhouse.net, netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: Allow tun-interfaces as slaves
Date: Wed, 10 Aug 2016 15:00:55 -0700 [thread overview]
Message-ID: <20160810220055.GE5019@cork> (raw)
In-Reply-To: <20160810212649.GD5019@cork>
On Wed, Aug 10, 2016 at 02:26:49PM -0700, Jörn Engel wrote:
>
> Having to set one more parameter is a bit annoying. It would have to be
> documented in a prominent place and people would still often miss it.
> So I wonder if we can make the interface a little nicer.
>
> Options:
> - If there are no slaves yet and the first slave added is tun, we trust
> the users to know what they are doing. Automatically set
> bond->params.fail_over_mac = BOND_FOM_KEEPMAC
> Maybe do a printk to inform the user in case of a mistake.
> - If we get an error and the slave device is tun, do a printk giving the
> user enough information to find this parameter.
>
> I'm leaning towards the former, but you probably know a reason why I am
> wrong again.
Patch below is an implementation of the former. Not sure if something
like this is worth considering.
Jörn
next prev parent reply other threads:[~2016-08-10 22:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 21:15 [Regression] Bonding no longer support tun-interfaces Jörn Engel
2016-08-08 21:15 ` Jörn Engel
2016-08-08 21:17 ` David Miller
2016-08-08 21:21 ` Jörn Engel
2016-08-08 21:48 ` [PATCH] bonding: Allow tun-interfaces as slaves Jörn Engel
2016-08-09 2:18 ` Ding Tianhong
2016-08-09 3:09 ` Jörn Engel
2016-08-09 5:29 ` zhuyj
2016-08-09 13:28 ` Ding Tianhong
2016-08-09 18:08 ` Jörn Engel
2016-08-09 19:06 ` David Miller
2016-08-09 21:10 ` Jörn Engel
2016-08-09 23:51 ` Jay Vosburgh
2016-08-10 1:06 ` Ding Tianhong
2016-08-10 9:27 ` Ding Tianhong
2016-08-10 17:41 ` Jay Vosburgh
2016-08-11 1:20 ` Ding Tianhong
2016-08-10 21:26 ` Jörn Engel
2016-08-10 22:00 ` Jörn Engel [this message]
2016-08-11 0:58 ` Jay Vosburgh
2016-08-11 1:37 ` Ding Tianhong
2016-08-11 18:24 ` Jörn Engel
2016-08-29 22:49 ` Jörn Engel
2016-08-30 1:44 ` Ding Tianhong
2016-08-09 5:52 ` Ding Tianhong
2016-08-09 18:21 ` Jay Vosburgh
2016-08-09 18:40 ` Jörn Engel
2016-08-09 19:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810220055.GE5019@cork \
--to=joern@purestorage.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=jay.vosburgh@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.