Re: [PATCHv2] fsck: fix strange logic

[Theodore Ts'o <tytso@mit.edu>]

On Tue, Aug 09, 2016 at 02:27:09PM -0600, Andreas Dilger wrote:
> llvm warns about the confusingly written comparison:
> 
>                               !strncmp(argv[i+1], "-", 1) == 0) {
>     misc/fsck.c:1178 col 9: warning: logical not is only applied to
>       the left hand side of comparison [-Wlogical-not-parentheses]
>     misc/fsck.c:1178 col 9: note: add parentheses after the '!' to
>       evaluate the comparison first
>     misc/fsck.c:1178 col 9: note: add parentheses around left hand
>       side expression to silence this warning
> 
> It makes sense to simplify this to a character comparison rather
> than using strncmp() to check only one character.
> 
> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>

Thanks, applied.

						- Ted