Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1470817370-145190-1-git-send-email-pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1470153479-6507-1-git-send-email-minyard@acm.org -> patchew/1470153479-6507-1-git-send-email-minyard@acm.org
 * [new tag]         patchew/1470153537-6588-1-git-send-email-minyard@acm.org -> patchew/1470153537-6588-1-git-send-email-minyard@acm.org
 * [new tag]         patchew/1470758127-17769-1-git-send-email-alex.bennee@linaro.org -> patchew/1470758127-17769-1-git-send-email-alex.bennee@linaro.org
Switched to a new branch 'test'
c4d842b checkpatch: default to success if only warnings
51a3cf7 checkpatch: bump most warnings to errors
f309450 CODING_STYLE, checkpatch: update line length rules
3942f8e checkpatch: check for CVS keywords on all sources
7cde082 checkpatch: tweak the files in which TABs are checked

=== OUTPUT BEGIN ===
Checking PATCH 1/5: checkpatch: tweak the files in which TABs are checked...
WARNING: line over 80 characters
#34: FILE: scripts/checkpatch.pl:1357:
+		next if ($realfile =~ /(checkpatch|get_maintainer|texi2pod)\.pl$/);

total: 0 errors, 1 warnings, 22 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: checkpatch: check for CVS keywords on all sources...
ERROR: line over 90 characters
#23: FILE: scripts/checkpatch.pl:1356:
+			WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);

total: 1 errors, 0 warnings, 22 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/5: CODING_STYLE, checkpatch: update line length rules...
Checking PATCH 4/5: checkpatch: bump most warnings to errors...
ERROR: line over 90 characters
#38: FILE: scripts/checkpatch.pl:1350:
+			ERROR("unnecessary whitespace before a quoted newline\n" . $herecurr);

ERROR: line over 90 characters
#44: FILE: scripts/checkpatch.pl:1355:
+			ERROR("adding a line without newline at end of file\n" . $herecurr);

ERROR: line over 90 characters
#50: FILE: scripts/checkpatch.pl:1360:
+			ERROR("CVS style keyword markers, these will _not_ be updated\n". $herecurr);

ERROR: line over 90 characters
#59: FILE: scripts/checkpatch.pl:1506:
+					ERROR("trailing semicolon indicates no statements, indent implies otherwise\n" .

ERROR: line over 90 characters
#68: FILE: scripts/checkpatch.pl:1594:
+				ERROR("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");

ERROR: line over 90 characters
#77: FILE: scripts/checkpatch.pl:1772:
+				ERROR("space prohibited between function name and open parenthesis '('\n" . $herecurr);

ERROR: line over 90 characters
#86: FILE: scripts/checkpatch.pl:2011:
+				ERROR("return of an errno should typically be -ve (return -$1)\n" . $herecurr);

ERROR: line over 90 characters
#95: FILE: scripts/checkpatch.pl:2083:
+			ERROR("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);

ERROR: line over 90 characters
#104: FILE: scripts/checkpatch.pl:2139:
+			ERROR("Whitespace after \\ makes next lines useless\n" . $herecurr);

ERROR: line over 90 characters
#113: FILE: scripts/checkpatch.pl:2291:
+					ERROR("braces {} are necessary for all arms of this statement\n" . $herectx);

ERROR: line over 90 characters
#122: FILE: scripts/checkpatch.pl:2359:
+				ERROR("braces {} are necessary even for single statement blocks\n" . $herectx);

ERROR: line over 90 characters
#130: FILE: scripts/checkpatch.pl:2366:
+			ERROR("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);

WARNING: line over 80 characters
#136: FILE: scripts/checkpatch.pl:2371:
+			ERROR("if this code is redundant consider removing it\n" .

ERROR: line over 90 characters
#145: FILE: scripts/checkpatch.pl:2379:
+				ERROR("g_free(NULL) is safe this check is probably not required\n" . $hereprev);

WARNING: line over 80 characters
#154: FILE: scripts/checkpatch.pl:2397:
+				ERROR("memory barrier without comment\n" . $herecurr);

ERROR: line over 90 characters
#162: FILE: scripts/checkpatch.pl:2404:
+			ERROR("architecture specific defines should be avoided\n" .  $herecurr);

ERROR: line over 90 characters
#168: FILE: scripts/checkpatch.pl:2409:
+			ERROR("storage class should be at the beginning of the declaration\n" . $herecurr)

ERROR: line over 90 characters
#186: FILE: scripts/checkpatch.pl:2438:
+				ERROR("externs should be avoided in .c files\n" .  $herecurr);

ERROR: line over 90 characters
#191: FILE: scripts/checkpatch.pl:2442:
+				ERROR("arguments for function declarations should follow identifier\n" . $herecurr);

WARNING: line over 80 characters
#198: FILE: scripts/checkpatch.pl:2448:
+			ERROR("externs should be avoided in .c files\n" .  $herecurr);

ERROR: line over 90 characters
#205: FILE: scripts/checkpatch.pl:2454:
+				ERROR("unnecessary cast may hide bugs, use g_$1new$3 instead\n" . $herecurr);

ERROR: line over 90 characters
#208: FILE: scripts/checkpatch.pl:2456:
+				ERROR("unnecessary cast may hide bugs, use g_$1renew$3 instead\n" . $herecurr);

ERROR: line over 90 characters
#215: FILE: scripts/checkpatch.pl:2462:
+			ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);

WARNING: line over 80 characters
#221: FILE: scripts/checkpatch.pl:2467:
+			ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr);

ERROR: line over 90 characters
#226: FILE: scripts/checkpatch.pl:2471:
+			ERROR("please use block_init(), type_init() etc. instead of module_init()\n" . $herecurr);

ERROR: line over 90 characters
#244: FILE: scripts/checkpatch.pl:2506:
+				ERROR("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);

WARNING: line over 80 characters
#261: FILE: scripts/checkpatch.pl:2530:
+		ERROR("Error messages should not contain newlines\n" . $herecurr);

WARNING: line over 80 characters
#270: FILE: scripts/checkpatch.pl:2551:
+			ERROR("Error messages should not contain newlines\n" . $herecurr);

total: 22 errors, 6 warnings, 237 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/5: checkpatch: default to success if only warnings...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org