From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH v2 0/6] de-stage SW_SYNC validation frawework Date: Thu, 11 Aug 2016 10:24:35 +0100 Message-ID: <20160811092435.GN10429@imgtec.com> References: <1470691462-19140-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E5F86E91F for ; Thu, 11 Aug 2016 09:24:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1470691462-19140-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Riley Andrews , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , pavel@ucw.cz, Daniel Vetter , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBdWcgMDgsIDIwMTYgYXQgMDY6MjQ6MTZQTSAtMDMwMCwgR3VzdGF2byBQYWRvdmFu IHdyb3RlOgo+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9y YS5jby51az4KPiAKPiBIaSBHcmVnLAo+IAo+IFRoaXMgaXMgdGhlIGxhc3Qgc3RlcCBpbiB0aGUg U3luYyBGcmFtd29yayBkZS1zdGFnZSB0YXNrLiBJdCBkZS1zdGFnZQo+IHRoZSBTV19TWU5DIHZh bGlkYXRpb24gZnJhbWV3b3JrIGFuZCB0aGUgc3luY19kZWJ1ZyBpbmZvIGRlYnVnZnMgZmlsZS4K PiAKPiBUaGUgZmlyc3QgMiBwYXRjaGVzIGFyZSBjbGVhbiB1cCBhbmQgaW1wcm92ZW1lbnRzIGFu ZCB0aGUgcmVzdCBpcyBwcmVwYXJhdGlvbgo+IHRvIGRlLXN0YWdlIGFuZCB0aGVuIGZpbmFsbHkg dGhlIGFjdHVhbCBkZS1zdGFnZS4KPiAKPiB2MjogCj4gIC0gYWRkIGRvY3VtZW50YXRpb24gYWJv dXQgdGhlIFNXX1NZTkMgaW9jdGwgQVBJIChjb21tZW50cyBmcm9tIFBhdmVsIE1hY2hlaykKPiAg LSByZW1vdmUgZm9yIG5vdyBwYXRjaCB0byBhZGQgc3luY19wdCBuYW1lIHRvIGRlYnVnZnMKPiAK PiBQbGVhc2UgcmV2aWV3LAo+IAo+IEd1c3Rhdm8KPiAKPiAtLS0KPiBHdXN0YXZvIFBhZG92YW4g KDYpOgo+ICAgc3RhZ2luZy9hbmRyb2lkOiByZW1vdmUgZG9jIGZyb20gc3dfc3luYwo+ICAgc3Rh Z2luZy9hbmRyb2lkOiBkbyBub3QgbGV0IHVzZXJzcGFjZSB0cmlnZ2VyIFdBUk5fT04KPiAgIHN0 YWdpbmcvYW5kcm9pZDogbW92ZSB0cmFjZS9zeW5jLmggdG8gc3luY190cmFjZS5oCj4gICBzdGFn aW5nL2FuZHJvaWQ6IHByZXBhcmUgc3dfc3luYyBmaWxlcyBmb3IgZGUtc3RhZ2luZwo+ICAgc3Rh Z2luZy9hbmRyb2lkOiBhZGQgRG9jIGZvciBTV19TWU5DIGlvY3RsIGludGVyZmFjZQo+ICAgZG1h LWJ1Zi9zd19zeW5jOiBkZS1zdGFnZSBTV19TWU5DCj4gCj4gIGRyaXZlcnMvZG1hLWJ1Zi9LY29u ZmlnICAgICAgICAgICAgICB8ICAxMyArKwo+ICBkcml2ZXJzL2RtYS1idWYvTWFrZWZpbGUgICAg ICAgICAgICAgfCAgIDEgKwo+ICBkcml2ZXJzL2RtYS1idWYvc3dfc3luYy5jICAgICAgICAgICAg fCAzNDkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9kbWEt YnVmL3N5bmNfZGVidWcuYyAgICAgICAgIHwgMjMwICsrKysrKysrKysrKysrKysrKysrKysrCj4g IGRyaXZlcnMvZG1hLWJ1Zi9zeW5jX2RlYnVnLmggICAgICAgICB8ICA2OSArKysrKysrCj4gIGRy aXZlcnMvZG1hLWJ1Zi9zeW5jX3RyYWNlLmggICAgICAgICB8ICAzMiArKysrCj4gIGRyaXZlcnMv c3RhZ2luZy9hbmRyb2lkL0tjb25maWcgICAgICB8ICAxMyAtLQo+ICBkcml2ZXJzL3N0YWdpbmcv YW5kcm9pZC9NYWtlZmlsZSAgICAgfCAgIDEgLQo+ICBkcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9z d19zeW5jLmMgICAgfCAzNDQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBk cml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9zeW5jX2RlYnVnLmMgfCAyMzAgLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KPiAgZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQvc3luY19kZWJ1Zy5oIHwgIDg0IC0t LS0tLS0tLQo+ICBkcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC90cmFjZS9zeW5jLmggfCAgMzIgLS0t LQo+ICAxMiBmaWxlcyBjaGFuZ2VkLCA2OTQgaW5zZXJ0aW9ucygrKSwgNzA0IGRlbGV0aW9ucygt KQoKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZG1hLWJ1Zi9zd19zeW5jLmMKPiAgY3Jl YXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZG1hLWJ1Zi9zeW5jX2RlYnVnLmMKPiAgY3JlYXRlIG1v ZGUgMTAwNjQ0IGRyaXZlcnMvZG1hLWJ1Zi9zeW5jX2RlYnVnLmgKPiAgY3JlYXRlIG1vZGUgMTAw NjQ0IGRyaXZlcnMvZG1hLWJ1Zi9zeW5jX3RyYWNlLmgKPiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGRy aXZlcnMvc3RhZ2luZy9hbmRyb2lkL3N3X3N5bmMuYwo+ICBkZWxldGUgbW9kZSAxMDA2NDQgZHJp dmVycy9zdGFnaW5nL2FuZHJvaWQvc3luY19kZWJ1Zy5jCj4gIGRlbGV0ZSBtb2RlIDEwMDY0NCBk cml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9zeW5jX2RlYnVnLmgKPiAgZGVsZXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvc3RhZ2luZy9hbmRyb2lkL3RyYWNlL3N5bmMuaAoKV2hlbiB5b3Ugc2VuZCB5b3Vy IG5leHQgcmV2aXNpb24sIGNvdWxkIHlvdSB1c2UgYGdpdCBmb3JtYXQtcGF0Y2ggLU1gPwpBIGdv b2QgOTUlIG9mIHRoZSBsaW5lcyBpbiB0aGVzZSBwYXRjaGVzIGFyZW4ndCBhY3R1YWxseSBtb2Rp ZmllZCwganVzdAptb3ZlZCBhcm91bmQsIHdoaWNoIG1ha2VzIGl0IG11Y2ggaGFyZGVyIHRvIHNw b3QgdGhlIGFjdHVhbCBjaGFuZ2VzIDopCgpDaGVlcnMsCiAgRXJpYwoKPiAKPiAtLSAKPiAyLjUu NQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932799AbcHKJYu (ORCPT ); Thu, 11 Aug 2016 05:24:50 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:18804 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752307AbcHKJYs (ORCPT ); Thu, 11 Aug 2016 05:24:48 -0400 Date: Thu, 11 Aug 2016 10:24:35 +0100 From: Eric Engestrom To: Gustavo Padovan CC: Greg Kroah-Hartman , , Daniel Stone , Daniel Vetter , Riley Andrews , , , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , , Gustavo Padovan , John Harrison Subject: Re: [PATCH v2 0/6] de-stage SW_SYNC validation frawework Message-ID: <20160811092435.GN10429@imgtec.com> References: <1470691462-19140-1-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1470691462-19140-1-git-send-email-gustavo@padovan.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-Originating-IP: [10.60.4.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2016 at 06:24:16PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi Greg, > > This is the last step in the Sync Framwork de-stage task. It de-stage > the SW_SYNC validation framework and the sync_debug info debugfs file. > > The first 2 patches are clean up and improvements and the rest is preparation > to de-stage and then finally the actual de-stage. > > v2: > - add documentation about the SW_SYNC ioctl API (comments from Pavel Machek) > - remove for now patch to add sync_pt name to debugfs > > Please review, > > Gustavo > > --- > Gustavo Padovan (6): > staging/android: remove doc from sw_sync > staging/android: do not let userspace trigger WARN_ON > staging/android: move trace/sync.h to sync_trace.h > staging/android: prepare sw_sync files for de-staging > staging/android: add Doc for SW_SYNC ioctl interface > dma-buf/sw_sync: de-stage SW_SYNC > > drivers/dma-buf/Kconfig | 13 ++ > drivers/dma-buf/Makefile | 1 + > drivers/dma-buf/sw_sync.c | 349 +++++++++++++++++++++++++++++++++++ > drivers/dma-buf/sync_debug.c | 230 +++++++++++++++++++++++ > drivers/dma-buf/sync_debug.h | 69 +++++++ > drivers/dma-buf/sync_trace.h | 32 ++++ > drivers/staging/android/Kconfig | 13 -- > drivers/staging/android/Makefile | 1 - > drivers/staging/android/sw_sync.c | 344 ---------------------------------- > drivers/staging/android/sync_debug.c | 230 ----------------------- > drivers/staging/android/sync_debug.h | 84 --------- > drivers/staging/android/trace/sync.h | 32 ---- > 12 files changed, 694 insertions(+), 704 deletions(-) > create mode 100644 drivers/dma-buf/sw_sync.c > create mode 100644 drivers/dma-buf/sync_debug.c > create mode 100644 drivers/dma-buf/sync_debug.h > create mode 100644 drivers/dma-buf/sync_trace.h > delete mode 100644 drivers/staging/android/sw_sync.c > delete mode 100644 drivers/staging/android/sync_debug.c > delete mode 100644 drivers/staging/android/sync_debug.h > delete mode 100644 drivers/staging/android/trace/sync.h When you send your next revision, could you use `git format-patch -M`? A good 95% of the lines in these patches aren't actually modified, just moved around, which makes it much harder to spot the actual changes :) Cheers, Eric > > -- > 2.5.5