All of lore.kernel.org
 help / color / mirror / Atom feed
From: Salah Triki <salah.triki@gmail.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	viro@zeniv.linux.org.uk
Subject: Re: [PATCH 1/4] befs: dump inode_size superblock information
Date: Thu, 11 Aug 2016 15:09:19 +0100	[thread overview]
Message-ID: <20160811140919.GA4140@pc> (raw)
In-Reply-To: <57AC4D83.1060305@osg.samsung.com>

On Thu, Aug 11, 2016 at 11:03:47AM +0100, Luis de Bethencourt wrote:
> On 10/08/16 22:41, Salah Triki wrote:
> > On Tue, Aug 09, 2016 at 11:01:23PM +0100, Luis de Bethencourt wrote:
> >> befs_dump_super_block() wasn't giving the inode_size information when
> >> dumping all elements of the superblock. Add this element to have complete
> >> information of the superblock.
> >>
> >> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> >> ---
> >>
> >> Hi,
> >>
> >> This is a series of superblock information related changes.
> >>
> >> Thanks,
> >> Luis
> >>
> >>  fs/befs/debug.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/fs/befs/debug.c b/fs/befs/debug.c
> >> index 4de7cff..85c1339 100644
> >> --- a/fs/befs/debug.c
> >> +++ b/fs/befs/debug.c
> >> @@ -169,6 +169,7 @@ befs_dump_super_block(const struct super_block *sb, befs_super_block * sup)
> >>  
> >>  	befs_debug(sb, "  num_blocks %llu", fs64_to_cpu(sb, sup->num_blocks));
> >>  	befs_debug(sb, "  used_blocks %llu", fs64_to_cpu(sb, sup->used_blocks));
> >> +	befs_debug(sb, "  inode_size %u", fs32_to_cpu(sb, sup->inode_size));
> >>  
> >>  	befs_debug(sb, "  magic2 %08x", fs32_to_cpu(sb, sup->magic2));
> >>  	befs_debug(sb, "  blocks_per_ag %u",
> >> -- 
> >> 2.5.1
> >>
> > 
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > 
> > Thanx
> > Salah
> > 
> 
> Hi Salah,
> 
> I prefer applying this series as a set. So will wait for your review of patch 2/4.
> 
> Let me know if you don't have time for it.
> 
> Thanks for the reviews,
> Luis

Hi Luis,

I am reviewing the patch 2/4 

regards,
Salah

      reply	other threads:[~2016-08-11 14:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09 22:01 [PATCH 1/4] befs: dump inode_size superblock information Luis de Bethencourt
2016-08-09 22:01 ` [PATCH 2/4] befs: add check for ag_shift in superblock Luis de Bethencourt
2016-08-11 14:58   ` Salah Triki
2016-08-09 22:01 ` [PATCH 3/4] befs: fix comment style Luis de Bethencourt
2016-08-10 21:42   ` Salah Triki
2016-08-09 22:01 ` [PATCH 4/4] befs: fix style issues in super.c Luis de Bethencourt
2016-08-10 21:44   ` Salah Triki
2016-08-10 21:41 ` [PATCH 1/4] befs: dump inode_size superblock information Salah Triki
2016-08-11 10:03   ` Luis de Bethencourt
2016-08-11 14:09     ` Salah Triki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160811140919.GA4140@pc \
    --to=salah.triki@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luisbg@osg.samsung.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.