From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>
Subject: Re: [PATCH] perf tools mem: Fix -t store option for record command
Date: Thu, 11 Aug 2016 11:46:46 -0300 [thread overview]
Message-ID: <20160811144646.GC27651@kernel.org> (raw)
In-Reply-To: <20160811120032.GA18451@krava>
Em Thu, Aug 11, 2016 at 02:00:32PM +0200, Jiri Olsa escreveu:
> On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu:
> > > Michael reported 'perf mem -t store record' being broken.
> > > The reason is latest rework of this area:
> > > commit acbe613e0c03 ("perf tools: Add monitored events array")
> > >
> > > We don't mark perf_mem_events store record when -t store
> > > option is specified.
> > >
> > > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
> > ^^^^^^
> > I'll remove this extraneous bit
>
> well, checkpatch script complained about that when
> I did not put it there.. but I don't mind ;-)
Huh?
[acme@jouet linux]$ grep Fixes /wb/1.patch
Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
[acme@jouet linux]$ scripts/checkpatch.pl /wb/1.patch
total: 0 errors, 0 warnings, 9 lines checked
/wb/1.patch has no obvious style problems and is ready for submission.
[acme@jouet linux]$ vim /wb/1.patch
[acme@jouet linux]$ grep Fixes /wb/1.patch
Fixes: acbe613e0c03 ("perf tools: Add monitored events array")
[acme@jouet linux]$ scripts/checkpatch.pl /wb/1.patch
total: 0 errors, 0 warnings, 9 lines checked
/wb/1.patch has no obvious style problems and is ready for submission.
[acme@jouet linux]$
- Arnaldo
next prev parent reply other threads:[~2016-08-11 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 8:50 [PATCH] perf tools mem: Fix -t store option for record command Jiri Olsa
2016-08-11 11:51 ` Arnaldo Carvalho de Melo
2016-08-11 12:00 ` Jiri Olsa
2016-08-11 14:46 ` Arnaldo Carvalho de Melo [this message]
2016-08-11 14:58 ` Jiri Olsa
2016-08-16 18:13 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811144646.GC27651@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.