From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v2 1/6] staging/android: remove doc from sw_sync Date: Thu, 11 Aug 2016 12:06:01 -0300 Message-ID: <20160811150601.GE2478@joana> References: <1470691462-19140-1-git-send-email-gustavo@padovan.org> <1470691462-19140-2-git-send-email-gustavo@padovan.org> <20160808234139.GD2946@xo-6d-61-c0.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f193.google.com (mail-yw0-f193.google.com [209.85.161.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EE0F6E944 for ; Thu, 11 Aug 2016 15:06:07 +0000 (UTC) Received: by mail-yw0-f193.google.com with SMTP id j12so283411ywb.1 for ; Thu, 11 Aug 2016 08:06:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160808234139.GD2946@xo-6d-61-c0.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Pavel Machek Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org SGkgUGF2ZWwsCgoyMDE2LTA4LTA5IFBhdmVsIE1hY2hlayA8cGF2ZWxAdWN3LmN6PjoKCj4gT24g TW9uIDIwMTYtMDgtMDggMTg6MjQ6MTcsIEd1c3Rhdm8gUGFkb3ZhbiB3cm90ZToKPiA+IEZyb206 IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPiA+IAo+ ID4gU1dfU1lOQyBzaG91bGQgbmV2ZXIgYmUgdXNlZCBieSBvdGhlciBwaWVjZXMgb2YgdGhlIGtl cm5lbCBhcGFydCBmcm9tCj4gPiBzeW5jX2RlYnVnIGFzIGl0IGlzIG9ubHkgYSBTeW5jIEZpbGUg VmFsaWRhdGlvbiBGcmFtZXdvcmssIHNvIGhpZGUgYW55Cj4gPiBpbmZvIHRvIGF2b2lkIGNvbmZ1 c2UgdGhpcyB3aXRoIGEgc3RhbmRhcmQga2VybmVsIGludGVybmFsIEFQSS4KPiAKPiA+IFNpZ25l ZC1vZmYtYnk6IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51 az4KPiAKPiBOQUsuCj4gCj4gSXQgaXMgdW5jbGVhciBmb3Igd2hhdCB0aGUgY29kZSBkb2VzLCBy ZW1vdmluZyB0aGUgZG9jcyBpcyBub3QgZ29pbmcgdG8gaGVscC4KPiAKPiBJZiBpdCBzaG91bGQg bm90IGJlIHVzZWQsIGRvY3VtZW50IHRoYXQgaXQgc2hvdWxkIG5vdCBiZSB1c2VkLi4gYnV0IG5v dCByZW1vdmUKPiB0aGUgZG9jcy4KCk9rYXksIEknbGwgc2tpcCB0aGlzIHBhdGNoLgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932338AbcHKPG3 (ORCPT ); Thu, 11 Aug 2016 11:06:29 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:33035 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839AbcHKPGZ (ORCPT ); Thu, 11 Aug 2016 11:06:25 -0400 Date: Thu, 11 Aug 2016 12:06:01 -0300 From: Gustavo Padovan To: Pavel Machek Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Sumit Semwal , Gustavo Padovan Subject: Re: [PATCH v2 1/6] staging/android: remove doc from sw_sync Message-ID: <20160811150601.GE2478@joana> Mail-Followup-To: Gustavo Padovan , Pavel Machek , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Sumit Semwal , Gustavo Padovan References: <1470691462-19140-1-git-send-email-gustavo@padovan.org> <1470691462-19140-2-git-send-email-gustavo@padovan.org> <20160808234139.GD2946@xo-6d-61-c0.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160808234139.GD2946@xo-6d-61-c0.localdomain> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, 2016-08-09 Pavel Machek : > On Mon 2016-08-08 18:24:17, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > SW_SYNC should never be used by other pieces of the kernel apart from > > sync_debug as it is only a Sync File Validation Framework, so hide any > > info to avoid confuse this with a standard kernel internal API. > > > Signed-off-by: Gustavo Padovan > > NAK. > > It is unclear for what the code does, removing the docs is not going to help. > > If it should not be used, document that it should not be used.. but not remove > the docs. Okay, I'll skip this patch.