From: hch <hch@lst.de>
To: Jeff Layton <jlayton@redhat.com>
Cc: hch <hch@lst.de>, Trond Myklebust <trondmy@primarydata.com>,
List Linux NFS Mailing <linux-nfs@vger.kernel.org>,
Thomas Haynes <loghyr@primarydata.com>,
Fields Bruce James <bfields@fieldses.org>
Subject: Re: CB_LAYOUTRECALL "deadlock" with in-kernel flexfiles server and XFS
Date: Thu, 11 Aug 2016 18:59:02 +0200 [thread overview]
Message-ID: <20160811165902.GA25717@lst.de> (raw)
In-Reply-To: <1470933227.30238.35.camel@redhat.com>
On Thu, Aug 11, 2016 at 12:33:47PM -0400, Jeff Layton wrote:
> On Thu, 2016-08-11 at 18:25 +0200, hch wrote:
> > Yeah, for file-like layouts there should be a flag in
> > struct nfsd4_layout_ops to disable recalls.
>
> I don't think disabling recalls would be enough, would it? XFS still
> wants to break_layout and won't proceed until the layout list is empty,
> AFAICT. We need some way to indicate to the lower filesystem not to
> call break_layout in this case.
XFS only cares about block-like layours where the client has direct
access to the file blocks. I'd need to look how to propagate the
flag into break_layout, but in principle we don't need to do any
recalls on truncate every for file and flexfile layouts.
>
> --
> Jeff Layton <jlayton@redhat.com>
---end quoted text---
next prev parent reply other threads:[~2016-08-11 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 15:23 CB_LAYOUTRECALL "deadlock" with in-kernel flexfiles server and XFS Jeff Layton
2016-08-11 15:55 ` Trond Myklebust
2016-08-11 16:06 ` Jeff Layton
2016-08-11 16:20 ` Trond Myklebust
2016-08-11 16:25 ` hch
2016-08-11 16:33 ` Jeff Layton
2016-08-11 16:59 ` hch [this message]
2016-08-11 17:10 ` Jeff Layton
2018-01-27 15:39 ` Benjamin Coddington
2018-01-27 21:41 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811165902.GA25717@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=loghyr@primarydata.com \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.