From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] poco: fix m68k compile
Date: Thu, 11 Aug 2016 21:27:07 +0300 [thread overview]
Message-ID: <20160811182707.GK845@tarshish> (raw)
In-Reply-To: <20160811181730.GA32099@waldemar-brodkorb.de>
Hi Waldemar,
On Thu, Aug 11, 2016 at 08:17:30PM +0200, Waldemar Brodkorb wrote:
> Add a patch from upstream to fix compile for m68k.
That is a little misleading. The patch is from the upstream double-conversion
project, not poco. poco apparently bundles code from double-conversion, so at
some point in the future poco may include this fix. But this patch is to
really (poco) upstream yet.
> Fixes:
> http://autobuild.buildroot.net/results/791917c1343f53e12f27b06cfd5e1d2e88078014/
> http://autobuild.buildroot.net/results/349d4b49d65a652551c4de20233684bb4ffa5ae3/
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> package/poco/0002-fix-m68k-double-conv-detect.patch | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 package/poco/0002-fix-m68k-double-conv-detect.patch
>
> diff --git a/package/poco/0002-fix-m68k-double-conv-detect.patch b/package/poco/0002-fix-m68k-double-conv-detect.patch
> new file mode 100644
> index 0000000..465ee64
> --- /dev/null
> +++ b/package/poco/0002-fix-m68k-double-conv-detect.patch
> @@ -0,0 +1,19 @@
> +Fixes compile for m68k.
> +
> +From upstream double-conversion:
> +https://github.com/google/double-conversion/blob/master/double-conversion/utils.h#L81
Mentioning the double-conversion commit id for this patch (da111796231) would
be nice. Besides, pointing to a specific line in a file on master branch is
not future proof.
baruch
> +
> +Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> +
> +diff -Nur poco-poco-1.7.2-release.orig/Foundation/src/utils.h poco-poco-1.7.2-release/Foundation/src/utils.h
> +--- poco-poco-1.7.2-release.orig/Foundation/src/utils.h 2016-03-19 08:19:35.000000000 +0100
> ++++ poco-poco-1.7.2-release/Foundation/src/utils.h 2016-08-11 02:55:02.827238119 +0200
> +@@ -63,6 +63,8 @@
> + defined(__AARCH64EL__) || \
> + defined(nios2) || defined(__nios2) || defined(__nios2__)
> + #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
> ++#elif defined(__mc68000__)
> ++#undef DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS
> + #elif defined(_M_IX86) || defined(__i386__) || defined(__i386)
> + #if defined(_WIN32)
> + // Windows uses a 64bit wide floating point stack.
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
prev parent reply other threads:[~2016-08-11 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 18:17 [Buildroot] [PATCH] poco: fix m68k compile Waldemar Brodkorb
2016-08-11 18:27 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811182707.GK845@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.