Re: [PATCH] kernel: show current values of ucounts

["Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>]

Quoting Andrei Vagin (avagin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org):
> On Thu, Aug 11, 2016 at 12:05:12PM -0700, Kees Cook wrote:
> > On Thu, Aug 11, 2016 at 12:02 AM, Andrei Vagin <avagin-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> wrote:
> > > This patch adds /proc/ucounts where all non-zero ucounts for a current
> > > userns are shown.
> > 
> > Eric would have a better sense of this, but I think we would normally
> > avoid putting something in the top-level /proc directory, especially
> > for namespace things (which IIUC usually appear in /proc/$pid/ns/).
> 
> /proc/$pid/ns contains links to namespaces handles. I am not sure that
> it's a good place for this file.
> 
> And I'm agree that it may be a good idea to move this file to
> /proc/$pid/.  It's like /proc/PID/net.
> 
> In thise case we will not need to switch into a user namespace to get
> its ucounts.
> 
> > 
> > Also, this should describe what ucounts are for people unfamiliar with
> > them. (i.e. this commit message doesn't really contain a detailed
> > description of what's being added.)
> > 
> > And finally, any changes to /proc need an associated entry in
> > Documentation/filesystems/proc.txt
> 
> I will add documentation and a better description for this patch.
> 
> Thank you for the comments.

I'd also use a more descriptive name - /proc/pid/userns_counts?
ucounts makes me think microcounts.