All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org,
	Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nf-next V2] netfilter: conntrack: simplify the code by using nf_conntrack_get_ht
Date: Fri, 12 Aug 2016 12:34:42 +0200	[thread overview]
Message-ID: <20160812103442.GA3484@salvia> (raw)
In-Reply-To: <1469878973-15201-1-git-send-email-zlpnobody@163.com>

On Sat, Jul 30, 2016 at 07:42:53PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
> 
> Since Commit 64b87639c9cb ("netfilter: conntrack: fix race between
> nf_conntrack proc read and hash resize") introdue the
> nf_conntrack_get_ht, so there's no need to check nf_conntrack_generation
> again and again to get the hash table and hash size.
> 
> But keep ____nf_conntrack_find unchanged, because it is performance
> critical path, increase the overhead of the function call is not so
> good.

I'm not very happy with this solution.

I think it is a good time to kill compat /proc/net/ip_conntrack*. That
has been there for so long already. So we can inline this function,
this is the only one that needs it to export it, right?

  reply	other threads:[~2016-08-12 10:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-30 11:42 [PATCH nf-next V2] netfilter: conntrack: simplify the code by using nf_conntrack_get_ht Liping Zhang
2016-08-12 10:34 ` Pablo Neira Ayuso [this message]
2016-08-12 11:12   ` Liping Zhang
2016-08-12 11:49     ` Pablo Neira Ayuso
2016-08-12 13:55       ` Liping Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160812103442.GA3484@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=liping.zhang@spreadtrum.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=zlpnobody@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.