From: Florian Westphal <fw@strlen.de>
To: lkp@lists.01.org
Subject: Re: [rhashtable] 4699858597: RIP: 0010:[<ffffffff81283b16>] [<ffffffff81283b16>] rhashtable_init
Date: Fri, 12 Aug 2016 13:09:45 +0200 [thread overview]
Message-ID: <20160812110945.GA25519@breakpoint.cc> (raw)
In-Reply-To: <57ada987.FqSw4QeFnftDImTI%fengguang.wu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
kernel test robot <fengguang.wu@intel.com> wrote:
> Greetings,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> https://github.com/0day-ci/linux Florian-Westphal/rhashtable-avoid-large-lock-array-allocations/20160812-101458
>
> commit 4699858597bcd0b212d28c96dad3ffdf18a43c02
> Author: Florian Westphal <fw@strlen.de>
> AuthorDate: Fri Aug 12 04:13:43 2016 +0200
> Commit: 0day robot <fengguang.wu@intel.com>
> CommitDate: Fri Aug 12 10:15:01 2016 +0800
Yes, problem is
max_t(unsigned int, 2 * L1_CACHE_BYTES / sizeof(spinlock_t), 1);
Which I took from inet_ehash_locks_alloc().
However, in inet_ehash_locks_alloc this is limited to a branch that
is guarded via
if (sizeof(spinlock_t) != 0) {
Dave already marked v1 'changes requested' in patchwork so no
further action is needed.
prev parent reply other threads:[~2016-08-12 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 10:48 [rhashtable] 4699858597: RIP: 0010:[<ffffffff81283b16>] [<ffffffff81283b16>] rhashtable_init kernel test robot
2016-08-12 11:09 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812110945.GA25519@breakpoint.cc \
--to=fw@strlen.de \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.