diff for duplicates of <20160812145212.GF1041@n2100.armlinux.org.uk> diff --git a/a/1.txt b/N1/1.txt index 7b4a194..6455987 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -24,7 +24,7 @@ On Fri, Aug 12, 2016 at 04:38:04PM +0200, Hans Verkuil wrote: > >+ u16 addresses; > >+ u8 buf[2]; > >+ -> >+ if (addr = CEC_LOG_ADDR_INVALID) +> >+ if (addr == CEC_LOG_ADDR_INVALID) > >+ addresses = priv->addresses = BIT(15); > > I saw this in patch 4/5 as well: why set bit 15? I would expect that this diff --git a/a/content_digest b/N1/content_digest index 9cb9684..5314e24 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,16 +1,10 @@ "ref\020160812141421.GB1041@n2100.armlinux.org.uk\0" "ref\0E1bYDEx-0004ry-Jg@rmk-PC.armlinux.org.uk\0" "ref\0a9bc07ee-ae77-1791-ccf8-cb654cd4c302@cisco.com\0" - "From\0Russell King - ARM Linux <linux@armlinux.org.uk>\0" - "Subject\0Re: [PATCH RFC 5/5] drm/i2c: add tda998x/tda9950 CEC driver\0" - "Date\0Fri, 12 Aug 2016 14:52:13 +0000\0" - "To\0Hans Verkuil <hansverk@cisco.com>\0" - "Cc\0linux-fbdev@vger.kernel.org" - David Airlie <airlied@linux.ie> - dri-devel@lists.freedesktop.org - Tomi Valkeinen <tomi.valkeinen@ti.com> - Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> - " linux-arm-kernel@lists.infradead.org\0" + "From\0linux@armlinux.org.uk (Russell King - ARM Linux)\0" + "Subject\0[PATCH RFC 5/5] drm/i2c: add tda998x/tda9950 CEC driver\0" + "Date\0Fri, 12 Aug 2016 15:52:13 +0100\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Fri, Aug 12, 2016 at 04:38:04PM +0200, Hans Verkuil wrote:\n" @@ -39,7 +33,7 @@ "> >+\tu16 addresses;\n" "> >+\tu8 buf[2];\n" "> >+\n" - "> >+\tif (addr = CEC_LOG_ADDR_INVALID)\n" + "> >+\tif (addr == CEC_LOG_ADDR_INVALID)\n" "> >+\t\taddresses = priv->addresses = BIT(15);\n" "> \n" "> I saw this in patch 4/5 as well: why set bit 15? I would expect that this\n" @@ -58,4 +52,4 @@ "FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up\n" according to speedtest.net. -b83b4e60c5fbdfca3173d2c78787c7f79c96bee08d8f06d42a5d1ed923a66dd5 +877ac4e10e7df58d090661daaf32edccbc0465cd8af0759a98691f015e4f5a90
diff --git a/a/1.txt b/N2/1.txt index 7b4a194..6455987 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -24,7 +24,7 @@ On Fri, Aug 12, 2016 at 04:38:04PM +0200, Hans Verkuil wrote: > >+ u16 addresses; > >+ u8 buf[2]; > >+ -> >+ if (addr = CEC_LOG_ADDR_INVALID) +> >+ if (addr == CEC_LOG_ADDR_INVALID) > >+ addresses = priv->addresses = BIT(15); > > I saw this in patch 4/5 as well: why set bit 15? I would expect that this diff --git a/a/content_digest b/N2/content_digest index 9cb9684..c8d00d0 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\0a9bc07ee-ae77-1791-ccf8-cb654cd4c302@cisco.com\0" "From\0Russell King - ARM Linux <linux@armlinux.org.uk>\0" "Subject\0Re: [PATCH RFC 5/5] drm/i2c: add tda998x/tda9950 CEC driver\0" - "Date\0Fri, 12 Aug 2016 14:52:13 +0000\0" + "Date\0Fri, 12 Aug 2016 15:52:13 +0100\0" "To\0Hans Verkuil <hansverk@cisco.com>\0" "Cc\0linux-fbdev@vger.kernel.org" David Airlie <airlied@linux.ie> @@ -39,7 +39,7 @@ "> >+\tu16 addresses;\n" "> >+\tu8 buf[2];\n" "> >+\n" - "> >+\tif (addr = CEC_LOG_ADDR_INVALID)\n" + "> >+\tif (addr == CEC_LOG_ADDR_INVALID)\n" "> >+\t\taddresses = priv->addresses = BIT(15);\n" "> \n" "> I saw this in patch 4/5 as well: why set bit 15? I would expect that this\n" @@ -58,4 +58,4 @@ "FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up\n" according to speedtest.net. -b83b4e60c5fbdfca3173d2c78787c7f79c96bee08d8f06d42a5d1ed923a66dd5 +c7014784ef086e2f48dbc186fa756ff700e9032adc613621468ab90b7e527e2d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.