From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH v2] drm/i915: intel_dp_link_is_valid() should only return status of link Date: Fri, 12 Aug 2016 10:56:36 -0700 Message-ID: <20160812175636.GA379@intel.com> References: <1470954221-6474-1-git-send-email-manasi.d.navare@intel.com> <1470972795.10941.12.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id B0E1D6EBF7 for ; Fri, 12 Aug 2016 17:43:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1470972795.10941.12.camel@dk-H97M-D3H> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBdWcgMTEsIDIwMTYgYXQgMDg6MTg6NTRQTSAtMDcwMCwgUGFuZGl5YW4sIERoaW5h a2FyYW4gd3JvdGU6Cj4gT24gVGh1LCAyMDE2LTA4LTExIGF0IDE1OjIzIC0wNzAwLCBNYW5hc2kg TmF2YXJlIHdyb3RlOgo+ID4gSW50ZWxfZHBfbGlua19pc192YWxpZCgpIGZ1bmN0aW9uIHJlYWRz IHRoZSBMaW5rIHN0YXR1cyByZWdpc3RlcnMKPiA+IGFuZCByZXR1cm5zIGEgYm9vbGVhbiB0byBp bmRpY2F0ZSBsaW5rIGlzIHZhbGlkIG9yIG5vdC4KPiA+IElmIHRoZSBsaW5rIGhhcyBsb3N0IGxv Y2sgYW5kIGlzIG5vdCB2YWxpZCBhbnkgbW9yZSwgbGluawo+ID4gdHJhaW5pbmcgaXMgcGVyZm9y bWVkIG91dHNpZGUgdGhlIGZ1bmN0aW9uIGVsc2UgcHJldmlvdXNseSB0cmFpbmVkIGxpbmsKPiA+ IGlzIHJldGFpbmVkLgo+ID4gVGhpcyBnaXZlcyB1cyBmbGV4aWJpbGl0eSBvZiBjaGVja2luZyB3 aGV0aGVyIGxpbmsgaXMgdmFsaWQgYW5kIHRyYWluaW5nCj4gPiBpdCBpbmRlcGVuZGVudGx5Lgo+ ID4gCj4gPiB2MjoKPiA+ICogQ2hhbmdlZCB0aGUgZnVuY3Rpb24gbmFtZSBmcm9tIGludGVsX2Rw X2NoZWNrX2xpbmtfc3RhdHVzKCkKPiA+IHRvIGludGVsX2RwX2xpbmtfaXNfdmFsaWQoKSAgKEx1 a2FzIFd1bm5lcikKPiA+ICogQ2hlY2tzIGZvciBDUlRDIGFuZCBhY3RpdmUgQ1JUQyBhcmUgbW92 ZWQgb3V0c2lkZSB0aGUKPiA+IGludGVsX2RwX2xpbmtfaXNfdmFsaWQoKSBmdW5jdGlvbiAoUm9k cmlnbyBWaXZpKQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2ku ZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYyB8IDU2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IGluZGV4IDM2NGRiOTAuLjg5MTE0N2QgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBAQCAtMzg4MSwzNiArMzg4MSwzMyBA QCBnb19hZ2FpbjoKPiA+ICAJcmV0dXJuIC1FSU5WQUw7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRp YyB2b2lkCj4gPiAtaW50ZWxfZHBfY2hlY2tfbGlua19zdGF0dXMoc3RydWN0IGludGVsX2RwICpp bnRlbF9kcCkKPiA+ICtzdGF0aWMgYm9vbAo+ID4gK2ludGVsX2RwX2xpbmtfaXNfdmFsaWQoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ICB7Cj4gPiAtCXN0cnVjdCBpbnRlbF9lbmNvZGVy ICppbnRlbF9lbmNvZGVyID0gJmRwX3RvX2RpZ19wb3J0KGludGVsX2RwKS0+YmFzZTsKPiA+ICAJ c3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RwX3RvX2RldihpbnRlbF9kcCk7Cj4gPiAg CXU4IGxpbmtfc3RhdHVzW0RQX0xJTktfU1RBVFVTX1NJWkVdOwo+ID4gIAo+ID4gIAlXQVJOX09O KCFkcm1fbW9kZXNldF9pc19sb2NrZWQoJmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRl eCkpOwo+ID4gIAo+ID4gIAlpZiAoIWludGVsX2RwX2dldF9saW5rX3N0YXR1cyhpbnRlbF9kcCwg bGlua19zdGF0dXMpKSB7Cj4gPiAtCQlEUk1fRVJST1IoIkZhaWxlZCB0byBnZXQgbGluayBzdGF0 dXNcbiIpOwo+ID4gLQkJcmV0dXJuOwo+ID4gKwkJRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGdl dCBsaW5rIHN0YXR1c1xuIik7Cj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiAgCX0KPiA+ICAKPiA+ IC0JaWYgKCFpbnRlbF9lbmNvZGVyLT5iYXNlLmNydGMpCj4gPiAtCQlyZXR1cm47Cj4gPiArCS8q IENoZWNrIGlmIHRoZSBsaW5rIGlzIHZhbGlkIGJ5IHJlYWRpbmcgdGhlIGJpdHMgb2YgTGluayBz dGF0dXMKPiA+ICsJICogcmVnaXN0ZXJzCj4gPiArCSAqLwo+ID4gKwlpZiAoIWRybV9kcF9jaGFu bmVsX2VxX29rKGxpbmtfc3RhdHVzLCBpbnRlbF9kcC0+bGFuZV9jb3VudCkpIHsKPiA+ICsJCURS TV9ERUJVR19LTVMoIkNoYW5uZWwgRVEgb3IgQ1Igbm90IG9rLCBuZWVkIHRvIHJldHJhaW5cbiIp Owo+IGRybV9kcF9jaGFubmVsX2VxX29rKCkgZG9lcyBub3QgY2hlY2sgZm9yIENSLiBTaG91bGQg d2UganVzdCBzYXkKPiAiQ2hhbm5lbCBFUSBub3Qgb2siIHRvIHByZWVtcHQgYW1iaWd1aXR5IHdo aWxlIGRlYnVnZ2luZyA/CgpBY3R1YWxseSB0aGlzIG1hY3JvIGNoZWNrcyBmb3IgRFBfQ0hBTk5F TF9FUV9CSVRTIHdoaWNoIGlzIGRlZmluZWQgYXM6CiNkZWZpbmUgRFBfQ0hBTk5FTF9FUV9CSVRT IChEUF9MQU5FX0NSX0RPTkUgfCAgICAgICAgICAgXAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgRFBfTEFORV9DSEFOTkVMX0VRX0RPTkUgfCAgIFwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgIERQX0xBTkVfU1lNQk9MX0xPQ0tFRCkKU28gaXQgaW5jbHVkZXMgY2hlY2tpbmcgZm9yIENo YW5uZWwgRVEgYW5kIENsb2NrIFJlY292ZXJ5IENSIGJpdHMKCgo+IAo+ID4gKwkJcmV0dXJuIGZh bHNlOwo+ID4gKwl9Cj4gPiAgCj4gPiAtCWlmICghdG9faW50ZWxfY3J0YyhpbnRlbF9lbmNvZGVy LT5iYXNlLmNydGMpLT5hY3RpdmUpCj4gPiAtCQlyZXR1cm47Cj4gPiArCURSTV9ERUJVR19LTVMo IkxpbmsgaXMgZ29vZCwgbm8gbmVlZCB0byByZXRyYWluXG4iKTsKPiBUaGUgY2FsbGVyIGRvZXMg bm90IGV4cGVjdCB1cyB0byBsaW5rIHRyYWluIGFueW1vcmUsIEkgZG9uJ3QgdGhpbmsgd2UKPiBo YXZlIHRvIGV4cGxpY2l0bHkgc3RhdGUgIm5vIG5lZWQgdG8gcmV0cmFpbiIuIEFsc28sIGRvIHdl IG5lZWQgZGVidWcKPiBtZXNzYWdlcyBpZiB0aGUgbGluayBpcyBnb29kPwoKSSBhZ3JlZSAsIG1h eWJlIHRoaXMgaXMgbm90IG5lZWRlZC4gSSB3aWxsIHJlbW92ZSB0aGlzCgo+IAo+ID4gKwlyZXR1 cm4gdHJ1ZTsKPiA+ICAKPiA+IC0JLyogaWYgbGluayB0cmFpbmluZyBpcyByZXF1ZXN0ZWQgd2Ug c2hvdWxkIHBlcmZvcm0gaXQgYWx3YXlzICovCj4gPiAtCWlmICgoaW50ZWxfZHAtPmNvbXBsaWFu Y2VfdGVzdF90eXBlID09IERQX1RFU1RfTElOS19UUkFJTklORykgfHwKPiA+IC0JICAgICghZHJt X2RwX2NoYW5uZWxfZXFfb2sobGlua19zdGF0dXMsIGludGVsX2RwLT5sYW5lX2NvdW50KSkpIHsK PiA+IC0JCURSTV9ERUJVR19LTVMoIiVzOiBjaGFubmVsIEVRIG5vdCBvaywgcmV0cmFpbmluZ1xu IiwKPiA+IC0JCQkgICAgICBpbnRlbF9lbmNvZGVyLT5iYXNlLm5hbWUpOwo+ID4gLQkJaW50ZWxf ZHBfc3RhcnRfbGlua190cmFpbihpbnRlbF9kcCk7Cj4gPiAtCQlpbnRlbF9kcF9zdG9wX2xpbmtf dHJhaW4oaW50ZWxfZHApOwo+ID4gLQl9Cj4gPiAgfQo+ID4gIAo+ID4gKwo+ID4gIC8qCj4gPiAg ICogQWNjb3JkaW5nIHRvIERQIHNwZWMKPiA+ICAgKiA1LjEuMjoKPiA+IEBAIC0zOTI4LDYgKzM5 MjUsOCBAQCBzdGF0aWMgYm9vbAo+ID4gIGludGVsX2RwX3Nob3J0X3B1bHNlKHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHApCj4gPiAgewo+ID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50 ZWxfZHBfdG9fZGV2KGludGVsX2RwKTsKPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAq aW50ZWxfZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gPiArCXN0cnVjdCBp bnRlbF9lbmNvZGVyICppbnRlbF9lbmNvZGVyID0gJmludGVsX2RpZ19wb3J0LT5iYXNlOwo+ID4g IAl1OCBzaW5rX2lycV92ZWN0b3IgPSAwOwo+ID4gIAl1OCBvbGRfc2lua19jb3VudCA9IGludGVs X2RwLT5zaW5rX2NvdW50Owo+ID4gIAlib29sIHJldDsKPiA+IEBAIC0zOTY4LDggKzM5NjcsMTgg QEAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ICAJ CQlEUk1fREVCVUdfRFJJVkVSKCJDUCBvciBzaW5rIHNwZWNpZmljIGlycSB1bmhhbmRsZWRcbiIp Owo+ID4gIAl9Cj4gPiAgCj4gPiArCS8qIERvIG5vdCB0cmFpbiB0aGUgbGluayBpZiB0aGVyZSBp cyBubyBjcnRjICovCj4gPiArCWlmICghaW50ZWxfZW5jb2Rlci0+YmFzZS5jcnRjKQo+ID4gKwkJ cmV0dXJuIHRydWU7Cj4gPiArCWlmICghdG9faW50ZWxfY3J0YyhpbnRlbF9lbmNvZGVyLT5iYXNl LmNydGMpLT5hY3RpdmUpCj4gPiArCQlyZXR1cm4gdHJ1ZTsKPiA+ICsKPiBJIG1pZ2h0IGJlIGNv bXBsZXRlbHkgb2ZmIGJhc2UgaGVyZS4gU2hvdWxkbid0IHdlIGtlZXAgdGhlIGxpbmsgdmFsaWQK PiBpcnJlc3BlY3RpdmUgb2Ygd2hldGhlciB0aGVyZSBpcyBhbiBhY3RpdmUgY3J0Yz8gSSB0aG91 Z2h0IHRoYXQgaXMgd2hhdAo+IHRoZSByZWZhY3RvcmluZyBpcyBzdXBwb3NlZCB0byBlbmFibGUu IERvZXMgaW50ZWxfZHBfc2hvcnRfcHVsc2UoKSBnZXQKPiBjYWxsZWQgd2hlbiB0aGVyZSBpcyBh IGxpbmsgbG9zcyBkdXJpbmcgdXBmcm9udCBsaW5rIHRyYWluaW5nPyBBbmQgaW4KPiB0aGF0IGNh c2UsIHNob3VsZG4ndCB3ZSByZXRyYWluIGV2ZW4gd2l0aG91dCBhIGNydGM/IAoKV2UgY2Fubm90 IGV2ZXIgcmV0cmFpbiB3aXRob3V0IGEgQ1JUQy4gVGhpcyBjaGVjayBpcyBtb3JlIGZvciBtYWtp bmcgc3VyZSB0aGF0IHRoZSBjbG9ja3MKYXJlIHNldCB1cCBiZWZvZmUgd2UgdHJ5IHRvIHJldHJh aW4gZWxzZSB3ZSB3aWxsIHNlZSBBVVggY2hhbm5lbCBmYWlsdXJlcy4KSWYgSSB0cmFjayB0aGlz IGJhY2sgaW4gdGhlIGtlcm5lbCB0cmVlLCB0aGlzIGNoZWNrIHdhcyBhZGRlZCB0byBhdm9pZCB0 aGUgbG9jayB1cCBpc3N1ZXMgb24gc29tZQpwbGF0Zm9ybXMuCgo+IAo+IEJlc2lkZXMgdGhhdCwg aG93IGFib3V0IHVzaW5nIGp1c3Qgb25lIHJldHVybj8KPiAKPiBzdHJ1Y3QgZHJtX2NydGMgKmNy dGMgPSBpbnRlbF9lbmNvZGVyLT5iYXNlLmNydGM7Cj4gCj4gaWYgKGNydGMgPT0gTlVMTCB8fCAh dG9faW50ZWxfY3J0YyhjcnRjKS0+YWN0aXZlKQo+IAlyZXR1cm4gdHJ1ZTsKPiAKPgoKVGhlIG9u bHkgcHJvYmxlbSB3aXRoIGRvaW5nIGJvdGggdGhlc2UgY2hlY2tzIHRvZ2V0aGVyIGlzIHRoYXQg aWYgY3J0YyBpcyBOVUxMCnRoZW4gd2UgYXJlIHRyeWluZyB0byBkZXJlZmVyZW5jZSBhIE5VTEwg cG9pbnRlciBpbiB0aGUgc2Vjb25kIGNoZWNrLgpTbyBpdCBzaG91bGQgYmUgc2V1cWVudGlhbCwg Y2hlY2sgaWYgY3J0YyBpcyBhY3RpdmUgb25seSBpZiB0aGVyZSBpcyBjcnRjIGF2YWlsYWJsZS4K Ck1hbmFzaQogCj4gPiAgCWRybV9tb2Rlc2V0X2xvY2soJmRldi0+bW9kZV9jb25maWcuY29ubmVj dGlvbl9tdXRleCwgTlVMTCk7Cj4gPiAtCWludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKGludGVs X2RwKTsKPiA+ICsJaWYgKCFpbnRlbF9kcF9saW5rX2lzX3ZhbGlkKGludGVsX2RwKSB8fAo+ID4g KwkgICAgaW50ZWxfZHAtPmNvbXBsaWFuY2VfdGVzdF90eXBlID09IERQX1RFU1RfTElOS19UUkFJ TklORykgewo+ID4gKwkJaW50ZWxfZHBfc3RhcnRfbGlua190cmFpbihpbnRlbF9kcCk7Cj4gPiAr CQlpbnRlbF9kcF9zdG9wX2xpbmtfdHJhaW4oaW50ZWxfZHApOwo+ID4gKwl9Cj4gPiAgCWRybV9t b2Rlc2V0X3VubG9jaygmZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4KTsKPiA+ICAK PiA+ICAJcmV0dXJuIHRydWU7Cj4gPiBAQCAtNDI5OCw4ICs0MzA3LDE3IEBAIGludGVsX2RwX2xv bmdfcHVsc2Uoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9yKQo+ID4gIAkJ ICogY2hlY2sgbGlua3Mgc3RhdHVzLCB0aGVyZSBoYXMgYmVlbiBrbm93biBpc3N1ZXMgb2YKPiA+ ICAJCSAqIGxpbmsgbG9zcyB0cmlnZ2VycmluZyBsb25nIHB1bHNlISEhIQo+ID4gIAkJICovCj4g PiArCQkvKiBEbyBub3QgdHJhaW4gdGhlIGxpbmsgaWYgdGhlcmUgaXMgbm8gY3J0YyAqLwo+ID4g KwkJaWYgKCFpbnRlbF9lbmNvZGVyLT5iYXNlLmNydGMpCj4gPiArCQkJZ290byBvdXQ7Cj4gPiAr CQlpZiAoIXRvX2ludGVsX2NydGMoaW50ZWxfZW5jb2Rlci0+YmFzZS5jcnRjKS0+YWN0aXZlKQo+ ID4gKwkJCWdvdG8gb3V0Owo+ID4gKwo+ID4gIAkJZHJtX21vZGVzZXRfbG9jaygmZGV2LT5tb2Rl X2NvbmZpZy5jb25uZWN0aW9uX211dGV4LCBOVUxMKTsKPiA+IC0JCWludGVsX2RwX2NoZWNrX2xp bmtfc3RhdHVzKGludGVsX2RwKTsKPiA+ICsJCWlmICghaW50ZWxfZHBfbGlua19pc192YWxpZChp bnRlbF9kcCkpIHsKPiA+ICsJCQlpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKGludGVsX2RwKTsK PiA+ICsJCQlpbnRlbF9kcF9zdG9wX2xpbmtfdHJhaW4oaW50ZWxfZHApOwo+ID4gKwkJfQo+ID4g IAkJZHJtX21vZGVzZXRfdW5sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgp Owo+ID4gIAkJZ290byBvdXQ7Cj4gPiAgCX0KPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==