From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53109)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bYEig-0007sw-Jy
	for qemu-devel@nongnu.org; Fri, 12 Aug 2016 11:50:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bYEia-0003XT-O3
	for qemu-devel@nongnu.org; Fri, 12 Aug 2016 11:50:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bYEia-0003XP-IN
	for qemu-devel@nongnu.org; Fri, 12 Aug 2016 11:49:56 -0400
Date: Fri, 12 Aug 2016 18:49:52 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160812184938-mutt-send-email-mst@kernel.org>
References: <1470842980-32481-1-git-send-email-mst@redhat.com>
	<1470842980-32481-4-git-send-email-mst@redhat.com>
	<20160812063828.GG2759@al.usersys.redhat.com>
	<D0BB11C2-AA9A-4AC8-80CF-9927DF67834F@nutanix.com>
	<1956404709.2011431.1470986456062.JavaMail.zimbra@redhat.com>
	<CAFEAcA_uVHHFikzZKz_FeqYzasz=8vEA10=aOPPbHZ6Ketz_Yw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA_uVHHFikzZKz_FeqYzasz=8vEA10=aOPPbHZ6Ketz_Yw@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with
 set_mem_table.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <mlureau@redhat.com>, Prerna Saxena <prerna.saxena@nutanix.com>, Fam Zheng <famz@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, marcandre lureau <marcandre.lureau@redhat.com>

On Fri, Aug 12, 2016 at 01:01:16PM +0100, Peter Maydell wrote:
> On 12 August 2016 at 08:20, Marc-Andr=C3=A9 Lureau <mlureau@redhat.com>=
 wrote:
> > Hi
> >
> > ----- Original Message -----
> >> sent a follow-up response to GET_FEATURES), I am now wondering if th=
is patch
> >> may break existing vhost applications too ? If so, reverting it poss=
ibly
> >> better.
> >> What confuses me is why it doesn=E2=80=99t fail all the time, but on=
ly about 20% to
> >> 30% time as Fam reports.
> >>
> >> Thoughts : Michael, Fam, MarcAndre ?
> >
> > Indeed, I didn't ack that patch in the first place for that kind of r=
easons, so I would revert it.
>=20
>=20
> If somebody would like to send a revert-patch to the list I'll apply
> it to master (please cc me as I suspect the mailing list server is
> down at the moment...) I've been seeing these failures in the
> build tests I run for merges.
>=20
> thanks
> -- PMM

Will do right now.

--=20
MST