All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@gmail.com>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH] netfilter: remove ip_conntrack* sysctl compat code
Date: Sat, 13 Aug 2016 12:10:18 +0200	[thread overview]
Message-ID: <20160813101018.GC1376@salvia> (raw)
In-Reply-To: <CAML_gOe84HZUgCr+ECxAxgO-21BbwQtvfWV_V7DNQWQUuzhGiA@mail.gmail.com>

On Sat, Aug 13, 2016 at 03:09:14PM +0800, Liping Zhang wrote:
> Hi Pablo,
> 2016-08-12 19:47 GMT+08:00 Pablo Neira Ayuso <pablo@netfilter.org>:
> > diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
> > index dd2c43a..22558b7 100644
> > --- a/net/netfilter/nf_conntrack_core.c
> > +++ b/net/netfilter/nf_conntrack_core.c
> > @@ -161,10 +161,7 @@ static void nf_conntrack_all_unlock(void)
> >  }
> >
> >  unsigned int nf_conntrack_htable_size __read_mostly;
> > -EXPORT_SYMBOL_GPL(nf_conntrack_htable_size);
> 
> We still need to export nf_conntrack_htable_size, otherwise:
> 
> ERROR: "nf_conntrack_htable_size"
> [net/netfilter/nfnetlink_cttimeout.ko] undefined!
> ERROR: "nf_conntrack_htable_size"
> [net/netfilter/nf_conntrack_netlink.ko] undefined!
> ERROR: "nf_conntrack_htable_size"
> [net/ipv4/netfilter/nf_conntrack_ipv4.ko] undefined!

I see, will send a v2. Thanks!

      reply	other threads:[~2016-08-13 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12 11:47 [PATCH] netfilter: remove ip_conntrack* sysctl compat code Pablo Neira Ayuso
2016-08-13  7:09 ` Liping Zhang
2016-08-13 10:10   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160813101018.GC1376@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=zlpnobody@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.