All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v7 05/15] libxl: Load guest BIOS from file
Date: Mon, 15 Aug 2016 10:17:00 +0100	[thread overview]
Message-ID: <20160815091700.GO20641@citrix.com> (raw)
In-Reply-To: <57B18803.2070803@huawei.com>

On Mon, Aug 15, 2016 at 05:14:43PM +0800, Shannon Zhao wrote:
> 
> 
> On 2016/8/15 17:09, Wei Liu wrote:
> > On Mon, Aug 15, 2016 at 05:04:20PM +0800, Shannon Zhao wrote:
> > [...]
> >>> > >  
> >>> > > +const char *libxl__seabios_path(void)
> >>> > > +{
> >>> > > +    return SEABIOS_PATH;
> >>> > > +}
> >>> > > +
> >>> > > +const char *libxl__ovmf_path(void)
> >>> > > +{
> >>> > > +    return OVMF_PATH;
> >>> > > +}
> >>> > > +
> >> > Hi, I got bellow errors when compiling on ARM.
> >> > 
> >> > libxl_paths.c: In function 'libxl__seabios_path':
> >> > libxl_paths.c:40:12: error: 'SEABIOS_PATH' undeclared (first use in this
> >> > function)
> >> >      return SEABIOS_PATH;
> >> >             ^
> >> > libxl_paths.c:40:12: note: each undeclared identifier is reported only
> >> > once for each function it appears in
> >> > libxl_paths.c: In function 'libxl__ovmf_path':
> >> > libxl_paths.c:45:12: error: 'OVMF_PATH' undeclared (first use in this
> >> > function)
> >> >      return OVMF_PATH;
> >> >             ^
> >> > libxl_paths.c: In function 'libxl__seabios_path':
> >> > libxl_paths.c:41:1: error: control reaches end of non-void function
> >> > [-Werror=return-type]
> >> >  }
> >> >  ^
> >> > libxl_paths.c: In function 'libxl__ovmf_path':
> >> > libxl_paths.c:46:1: error: control reaches end of non-void function
> >> > [-Werror=return-type]
> >> >  }
> >> >  ^
> >> > cc1: all warnings being treated as errors
> >> > 
> > Have you tried to run ./autogen.sh in xen.git top-level directory?
> Eh, I only ran ./configure and make dist-tools as before. ./autogen.sh
> makes it work.
> 

Good to hear that solved your problem.

Anthony didn't commit the changes to configure that's why you saw those
errors.

Wei.

> Thanks,
> -- 
> Shannon
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-08-15  9:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 10:49 [PATCH v7 00/15] Load BIOS via toolstack instead of been embedded in hvmloader Anthony PERARD
2016-07-28 10:49 ` [PATCH v7 01/15] libxc: Rework extra module initialisation Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 02/15] libxc: Prepare a start info structure for hvmloader Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 03/15] configure: #define SEABIOS_PATH and OVMF_PATH Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 04/15] firmware/makefile: install BIOS blob Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 05/15] libxl: Load guest BIOS from file Anthony PERARD
2016-08-15  9:04   ` Shannon Zhao
2016-08-15  9:09     ` Wei Liu
2016-08-15  9:14       ` Shannon Zhao
2016-08-15  9:17         ` Wei Liu [this message]
2016-07-28 10:50 ` [PATCH v7 06/15] xen: Move the hvm_start_info C representation to the public headers Anthony PERARD
2016-07-28 13:23   ` Andrew Cooper
2016-08-03 15:43   ` Jan Beulich
2016-07-28 10:50 ` [PATCH v7 07/15] hvmloader: Grab the hvm_start_info pointer Anthony PERARD
2016-07-28 14:09   ` Andrew Cooper
2016-07-28 10:50 ` [PATCH v7 08/15] hvmloader: Locate the BIOS blob Anthony PERARD
2016-07-28 13:44   ` Andrew Cooper
2016-08-02 18:14     ` Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 09/15] hvmloader: Check modules whereabouts in perform_tests Anthony PERARD
2016-07-28 14:08   ` Andrew Cooper
2016-08-02 18:34     ` Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 10/15] hvmloader: Load SeaBIOS from hvm_start_info modules Anthony PERARD
2016-07-28 14:09   ` Andrew Cooper
2016-07-28 10:50 ` [PATCH v7 11/15] hvmloader: Load OVMF from modules Anthony PERARD
2016-07-28 14:11   ` Andrew Cooper
2016-07-28 10:50 ` [PATCH v7 12/15] hvmloader: bios->bios_load() now needs to be defined Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 13/15] hvmloader: Always build-in SeaBIOS and OVMF loader Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 14/15] configure: do not depend on SEABIOS_PATH or OVMF_PATH Anthony PERARD
2016-07-28 10:50 ` [PATCH v7 15/15] docs/misc/hvmlite: Point to the canonical definition of hvm_start_info Anthony PERARD
2016-08-01 12:29   ` Jan Beulich
2016-07-29  5:28 ` [PATCH v7 00/15] Load BIOS via toolstack instead of been embedded in hvmloader Boris Ostrovsky
2016-07-29  8:29   ` Wei Liu
2016-07-29 14:36     ` Boris Ostrovsky
2016-07-29 14:50       ` Wei Liu
2016-07-29 14:57         ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160815091700.GO20641@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.