From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 2/2] drm/fence: allow fence waiting to be interrupted by userspace Date: Mon, 15 Aug 2016 11:45:45 -0300 Message-ID: <20160815144545.GA9397@joana> References: <1470940785-25870-1-git-send-email-gustavo@padovan.org> <1470940785-25870-2-git-send-email-gustavo@padovan.org> <9e717fc1-e259-62ce-7e23-269c0db33f9a@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f193.google.com (mail-yw0-f193.google.com [209.85.161.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id C26EC8855B for ; Mon, 15 Aug 2016 14:45:50 +0000 (UTC) Received: by mail-yw0-f193.google.com with SMTP id j12so2378566ywb.1 for ; Mon, 15 Aug 2016 07:45:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <9e717fc1-e259-62ce-7e23-269c0db33f9a@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, m.chehab@samsung.com, Gustavo Padovan , John Harrison , laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org MjAxNi0wOC0xNSBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50 ZWwuY29tPjoKCj4gT3AgMTEtMDgtMTYgb20gMjA6Mzkgc2NocmVlZiBHdXN0YXZvIFBhZG92YW46 Cj4gPiBGcm9tOiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28u dWs+Cj4gPgo+ID4gSWYgdXNlcnNwYWNlIGlzIHJ1bm5pbmcgYW4gc3luY2hyb25vdXNseSBhdG9t aWMgY29tbWl0IGFuZCBpbnRlcnJ1cHRzIHRoZQo+ID4gYXRvbWljIG9wZXJhdGlvbiBkdXJpbmcg ZmVuY2Vfd2FpdCgpIGl0IHdpbGwgaGFuZyB1bnRpbCB0aGUgdGltZXIgZXhwaXJlcywKPiA+IHNv IGhlcmUgd2UgY2hhbmdlIHRoZSB3YWl0IHRvIGJlIGludGVycnVwdGlibGUgc28gaXQgc3RvcCBp bW1lZGlhdGVseSB3aGVuCj4gPiB1c2Vyc3BhY2Ugd2FudHMgdG8gcXVpdC4KPiA+Cj4gPiBBbHNv IGFkZHMgdGhlIG5lY2Vzc2FyeSBlcnJvciBjaGVja2luZyBmb3IgZmVuY2Vfd2FpdCgpLgo+ID4K PiA+IHYyOiBDb21tZW50IGJ5IERhbmllbCBWZXR0ZXIKPiA+IAktIEFkZCBlcnJvciBjaGVja2lu ZyBmb3IgZmVuY2Vfd2FpdCgpCj4gPgo+ID4gdjM6IFJlYmFzZSBvbiB0b3Agb2YgbmV3IGF0b21p YyBub2Jsb2NraW5nIHN1cHBvcnQKPiBNZWgsIEkgZG9uJ3QgbGlrZSB0aGUgc3dhcHBlZCBwYXJh bWV0ZXIgbXVjaCwgY291bGRuJ3Qgd2UgaW5mZXIgaXQgZnJvbSBpbnRyPyBvciByZW5hbWUgaW50 ciB0byBzd2FwcGVkPwoKRGVmaW5pdGVseSwgSSBkaWRuJ3QgcmVhbGl6ZWQgaXQgbXlzZWxmIHRo YXQgYm90aCB3ZXJlIHNheWluZyB0aGUgc2FtZQp0aGluZy4gVGhhbmtzIGZvciB0aGUgc3VnZ2Vz dHRpb24uCgpHdXN0YXZvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbcHOOpw (ORCPT ); Mon, 15 Aug 2016 10:45:52 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:36276 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901AbcHOOpv (ORCPT ); Mon, 15 Aug 2016 10:45:51 -0400 Date: Mon, 15 Aug 2016 11:45:45 -0300 From: Gustavo Padovan To: Maarten Lankhorst Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Gustavo Padovan Subject: Re: [PATCH 2/2] drm/fence: allow fence waiting to be interrupted by userspace Message-ID: <20160815144545.GA9397@joana> Mail-Followup-To: Gustavo Padovan , Maarten Lankhorst , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Gustavo Padovan References: <1470940785-25870-1-git-send-email-gustavo@padovan.org> <1470940785-25870-2-git-send-email-gustavo@padovan.org> <9e717fc1-e259-62ce-7e23-269c0db33f9a@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e717fc1-e259-62ce-7e23-269c0db33f9a@linux.intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-08-15 Maarten Lankhorst : > Op 11-08-16 om 20:39 schreef Gustavo Padovan: > > From: Gustavo Padovan > > > > If userspace is running an synchronously atomic commit and interrupts the > > atomic operation during fence_wait() it will hang until the timer expires, > > so here we change the wait to be interruptible so it stop immediately when > > userspace wants to quit. > > > > Also adds the necessary error checking for fence_wait(). > > > > v2: Comment by Daniel Vetter > > - Add error checking for fence_wait() > > > > v3: Rebase on top of new atomic noblocking support > Meh, I don't like the swapped parameter much, couldn't we infer it from intr? or rename intr to swapped? Definitely, I didn't realized it myself that both were saying the same thing. Thanks for the suggesttion. Gustavo