From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH 0/7] re-enable DAX PMD support Date: Mon, 15 Aug 2016 15:11:06 -0600 Message-ID: <20160815211106.GA31566@linux.intel.com> References: <20160815190918.20672-1-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ross Zwisler , "linux-kernel@vger.kernel.org" , Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Dave Chinner , Jan Kara , linux-ext4 , linux-fsdevel , Linux MM , "linux-nvdimm@lists.01.org" To: Dan Williams Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-ext4.vger.kernel.org On Mon, Aug 15, 2016 at 01:21:47PM -0700, Dan Williams wrote: > On Mon, Aug 15, 2016 at 12:09 PM, Ross Zwisler > wrote: > > DAX PMDs have been disabled since Jan Kara introduced DAX radix tree based > > locking. This series allows DAX PMDs to participate in the DAX radix tree > > based locking scheme so that they can be re-enabled. > > Looks good to me. > > > This series restores DAX PMD functionality back to what it was before it > > was disabled. There is still a known issue between DAX PMDs and hole > > punch, which I am currently working on and which I plan to address with a > > separate series. > > Perhaps we should hold off on applying patch 6 and 7 until after the > hole-punch fix is ready? Sure, I'm cool with holding off on patch 7 (the Kconfig change) until after the hole punch fix is ready. I don't see a reason to hold off on patch 6, though? It stands on it's own, implements the correct locking, and doesn't break anything. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ml01.01.org (Postfix) with ESMTP id AEF131A1E15 for ; Mon, 15 Aug 2016 14:11:07 -0700 (PDT) Date: Mon, 15 Aug 2016 15:11:06 -0600 From: Ross Zwisler Subject: Re: [PATCH 0/7] re-enable DAX PMD support Message-ID: <20160815211106.GA31566@linux.intel.com> References: <20160815190918.20672-1-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Theodore Ts'o , "linux-nvdimm@lists.01.org" , Dave Chinner , "linux-kernel@vger.kernel.org" , Linux MM , Andreas Dilger , Alexander Viro , Jan Kara , linux-fsdevel , linux-ext4 , Andrew Morton List-ID: On Mon, Aug 15, 2016 at 01:21:47PM -0700, Dan Williams wrote: > On Mon, Aug 15, 2016 at 12:09 PM, Ross Zwisler > wrote: > > DAX PMDs have been disabled since Jan Kara introduced DAX radix tree based > > locking. This series allows DAX PMDs to participate in the DAX radix tree > > based locking scheme so that they can be re-enabled. > > Looks good to me. > > > This series restores DAX PMD functionality back to what it was before it > > was disabled. There is still a known issue between DAX PMDs and hole > > punch, which I am currently working on and which I plan to address with a > > separate series. > > Perhaps we should hold off on applying patch 6 and 7 until after the > hole-punch fix is ready? Sure, I'm cool with holding off on patch 7 (the Kconfig change) until after the hole punch fix is ready. I don't see a reason to hold off on patch 6, though? It stands on it's own, implements the correct locking, and doesn't break anything. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932513AbcHOVLJ (ORCPT ); Mon, 15 Aug 2016 17:11:09 -0400 Received: from mga04.intel.com ([192.55.52.120]:52251 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115AbcHOVLI (ORCPT ); Mon, 15 Aug 2016 17:11:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,527,1464678000"; d="scan'208";a="156165393" Date: Mon, 15 Aug 2016 15:11:06 -0600 From: Ross Zwisler To: Dan Williams Cc: Ross Zwisler , "linux-kernel@vger.kernel.org" , "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Andrew Morton , Dave Chinner , Jan Kara , linux-ext4 , linux-fsdevel , Linux MM , "linux-nvdimm@lists.01.org" Subject: Re: [PATCH 0/7] re-enable DAX PMD support Message-ID: <20160815211106.GA31566@linux.intel.com> Mail-Followup-To: Ross Zwisler , Dan Williams , "linux-kernel@vger.kernel.org" , Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Dave Chinner , Jan Kara , linux-ext4 , linux-fsdevel , Linux MM , "linux-nvdimm@lists.01.org" References: <20160815190918.20672-1-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 15, 2016 at 01:21:47PM -0700, Dan Williams wrote: > On Mon, Aug 15, 2016 at 12:09 PM, Ross Zwisler > wrote: > > DAX PMDs have been disabled since Jan Kara introduced DAX radix tree based > > locking. This series allows DAX PMDs to participate in the DAX radix tree > > based locking scheme so that they can be re-enabled. > > Looks good to me. > > > This series restores DAX PMD functionality back to what it was before it > > was disabled. There is still a known issue between DAX PMDs and hole > > punch, which I am currently working on and which I plan to address with a > > separate series. > > Perhaps we should hold off on applying patch 6 and 7 until after the > hole-punch fix is ready? Sure, I'm cool with holding off on patch 7 (the Kconfig change) until after the hole punch fix is ready. I don't see a reason to hold off on patch 6, though? It stands on it's own, implements the correct locking, and doesn't break anything.