From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZUFc-0002ox-4Z for qemu-devel@nongnu.org; Mon, 15 Aug 2016 22:37:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZUFX-00022T-PH for qemu-devel@nongnu.org; Mon, 15 Aug 2016 22:37:11 -0400 Date: Tue, 16 Aug 2016 12:18:44 +1000 From: David Gibson Message-ID: <20160816021844.GA14530@voom.fritz.box> References: <1470388537-2908-1-git-send-email-clg@kaod.org> <1470388537-2908-3-git-send-email-clg@kaod.org> <1470390251.12584.157.camel@kernel.crashing.org> <1470437001.12584.170.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <1470437001.12584.170.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 06, 2016 at 08:43:21AM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2016-08-05 at 18:48 +0200, C=E9dric Le Goater wrote: > > The core initialization should be ok but building the device=A0 > > tree might be a bit of a burden if we have to 'cast' in the chip=A0 > > type we need. We will see. >=20 > We don't cast, we use a method. Right. You can have a look at the sPAPR VIO stuff for an example where we use a method in the individual devices to do the device specific fdt construction. >=20 > > So what would be the big differences with what we have today ?=A0=A0=A0 >=20 > The XSCOM controller has a different address decoding scheme, so > we'll have two variants and a base class there. The number and > location of functional units changes, so we'll probably need to make > them properties or something, the core XSCOM addressing is completely > different, we use PHB4 rather than PHB3, etc... >=20 > (Note that for PHB we should probably rename PHB3 to PnvPhb with a > subclass as well as there is a lot in common between the two, though > the PBCQ bit is quite different). >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXsngDAAoJEGw4ysog2bOSR+IQALaYuKMFH8xqP9AKyPRMa8mj QMtnt8DGlUU2He4cDIm9yu7a9gHJQDrPZrJv0x8GVYmLTo5xC+GZKbLScxRoHBqC eyn4duMalmVPC3RbZWNVwSh9hLj4vtu2+UwQtFEgLV35Q72AN1PLcDidCZh2ka1d YQU0aM6TH+qLQpOwnEcc2PokytjhKGJ6+xPUkxZyRhpiMloqL8uG8e1a0iO46pmv ppJvpb0yNXMz8XFoslXk3YqsDXvcO6EPrnmxMpUFOT0P78Umj8leJ3l9FU2Sylc1 3/CELjR8iAplvZAYwl4Pv/LreHC1t1wNEo4BYPzX8aVBsXNfQjNfkzBCtoK+B5Ip sZOgwvpyt3A26K7/8bHepoOiBgop2fq2AGnaGs8v02099GAZkJbow3mRd3O7XhF0 wfKk521vUGEQpeVFtkKz5MLNoUVFO7sO5ZF4UE3ktBcxzKePPq0NWQO4fgQWzF8G yJgFj+bSJWBtAditO4towlqBklRBy1uZxhba+depR+y87nDRdFB8X2bz64XiRYxd ktDnc+0vlQcSb8sWX7Kwp9PSZpW/aT97tbRZ1tH2O8F8x6ZL0fRKflm+PyMRbweN WufcVW04bt9Q9l9wjMeTyKYqN5FDDdjUbDDpLN/PFOf8AeMhgf/69JXQk7qppAeZ fBzLPdlMzi734GBSM9Ym =CFv3 -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J--