From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape`
Date: Mon, 15 Aug 2016 19:46:55 -0700 [thread overview]
Message-ID: <20160816024655.GH3482@linux.vnet.ibm.com> (raw)
In-Reply-To: <1471310212-4354-1-git-send-email-sj38.park@gmail.com>
On Tue, Aug 16, 2016 at 10:16:51AM +0900, SeongJae Park wrote:
> This commit modifies Makefile to check availability of `a2ping` and
> `inkscape` command as it already does for `dot` and `fig2eps`.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Applied both, thank you!
Thanx, Paul
> ---
> Makefile | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index b3d7c4c..60e8e96 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -41,6 +41,10 @@ DOT := $(shell which dot 2>/dev/null)
>
> FIG2EPS := $(shell which fig2eps 2>/dev/null)
>
> +A2PING := $(shell which a2ping 2>/dev/null)
> +
> +INKSCAPE := $(shell which inkscape 2>/dev/null)
> +
> default = $(PERFBOOK_DEFAULT)
>
> ifeq ($(default),)
> @@ -127,10 +131,16 @@ endif
>
> $(PDFTARGETS_OF_EPS): %.pdf: %.eps
> @echo "$< --> $@"
> +ifndef A2PING
> + $(error "$< --> $@: a2ping not found. Please install it.")
> +endif
> @a2ping --below --hires --bboxfrom=compute-gs $< $@ > /dev/null 2>&1
>
> $(PDFTARGETS_OF_SVG): %.pdf: %.svg
> @echo "$< --> $@"
> +ifndef INKSCAPE
> + $(error "$< --> $@: inkscape not found. Please install it.")
> +endif
> @inkscape --export-pdf=$@ $<
>
> clean:
> --
> 1.9.1
>
prev parent reply other threads:[~2016-08-16 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 1:16 [PATCH 1/2] Makefile: Check availability of `a2ping` and `inkscape` SeongJae Park
2016-08-16 1:16 ` [PATCH 2/2] FAQ-BUILD: Add package requirements for Fedora 24 SeongJae Park
2016-08-16 2:46 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816024655.GH3482@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=perfbook@vger.kernel.org \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.