From: Shawn Guo <shawnguo@kernel.org>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: drop DRIVER_HAVE_IRQ flag for some drivers
Date: Tue, 16 Aug 2016 14:55:12 +0800 [thread overview]
Message-ID: <20160816065512.GN500@tiger> (raw)
In-Reply-To: <20160812140331.GA1041@n2100.armlinux.org.uk>
On Fri, Aug 12, 2016 at 03:03:31PM +0100, Russell King - ARM Linux wrote:
> On Fri, Aug 12, 2016 at 01:15:37PM +0800, Shawn Guo wrote:
> > The drm driver feature flag DRIVER_HAVE_IRQ is used to indicates whether
> > the driver has an IRQ handler managed by the DRM core. Some drivers,
> > armada, etnaviv, kirin and sti, set this flag without .irq_handler setup
> > in drm_driver. These drivers manage IRQ handler by themselves and the
> > flag DRIVER_HAVE_IRQ makes no sense there.
>
> It's worth noting that DRIVER_HAVE_IRQ was required prior to:
>
> commit 4984979b9b9025a1cb9a9bea089d31a3e01ccff1
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Wed Aug 28 15:02:37 2013 +0200
>
> drm/irq: simplify irq checks in drm_wait_vblank
>
> to have working vblank. As this is no longer the case, this change
> looks sane.
Okay, I will improve the commit log and send v2 soon.
>
> >
> > Drop the flag for these drivers to avoid confusion.
> >
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> > drivers/gpu/drm/armada/armada_drv.c | 2 +-
> > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 +--
>
> For both of these,
>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks, Russell.
Shawn
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-08-16 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 5:15 [PATCH] drm: drop DRIVER_HAVE_IRQ flag for some drivers Shawn Guo
2016-08-12 14:03 ` Russell King - ARM Linux
2016-08-16 6:55 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816065512.GN500@tiger \
--to=shawnguo@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux@armlinux.org.uk \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.