All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_test: Propagate SIGINT to test process
Date: Tue, 16 Aug 2016 13:34:51 +0200	[thread overview]
Message-ID: <20160816113451.GA25092@rei.lan> (raw)
In-Reply-To: <321891608.1353493.1470404076410.JavaMail.zimbra@redhat.com>

Hi!
> This still gives me a warning:
>   tst_test.c: In function ???sigint_handler???:
>   tst_test.c:732:3: warning: ignoring return value of ???write???, declared with attribute warn_unused_result [-Wunused-result]
>    (void)write(2, SIGINT_MSG, sizeof(SIGINT_MSG) - 1);
>    ^
> We could use fprintf(stderr):
>   fprintf(stderr, "%s\n", SIGINT_MSG);

Ping.

What do you think about this?

Should we ignore the warning for the time being or add the dummy if ()
to silence it?

-- 
Cyril Hrubis
chrubis@suse.cz

  parent reply	other threads:[~2016-08-16 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 14:45 [LTP] [PATCH] tst_test: Propagate SIGINT to test process Cyril Hrubis
2016-08-05 13:34 ` Jan Stancek
2016-08-05 13:51   ` Peter Maydell
2016-08-09  9:26     ` Cyril Hrubis
2016-08-16 11:34   ` Cyril Hrubis [this message]
2016-08-16 11:50     ` Jan Stancek
2016-08-16 12:06       ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160816113451.GA25092@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.