From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8436431371481169028==" MIME-Version: 1.0 From: Aaron Lu To: lkp@lists.01.org Subject: Re: [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Date: Wed, 17 Aug 2016 15:53:57 +0800 Message-ID: <20160817075357.GA2558@aaronlu.sh.intel.com> In-Reply-To: <375f06dd-8439-bba3-8b45-781e1e48dc9c@intel.com> List-Id: --===============8436431371481169028== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2016 at 03:42:34PM +0800, Aaron Lu wrote: > On 08/17/2016 03:35 PM, Xin Long wrote: > >> include/net/sctp/structs.h | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h > >> index d8e464aacb20..932f2780d3a4 100644 > >> --- a/include/net/sctp/structs.h > >> +++ b/include/net/sctp/structs.h > >> @@ -602,6 +602,9 @@ struct sctp_chunk { > >> /* This needs to be recoverable for SCTP_SEND_FAILED events. */ > >> struct sctp_sndrcvinfo sinfo; > >> > >> + unsigned long prsctp_param; > >> + int sent_count; > >> + > >> /* Which association does this belong to? */ > >> struct sctp_association *asoc; > >> > >> -- > >> 2.5.5 > >> > >> Then the performance dropped to the same as the bisected commit > >> a6c2f792873a: > >> $ cat 4.7.0-rc6-01198-g98dd2532b14e/0/netperf.json > >> { > >> "netperf.Throughput_Mbps": [ > >> 754.494375 > >> ] > >> } > >> > >> I think this agrees with the perf data in that the newly added function > >> doesn't show up in the perf-profile but still, the performance drops. > >> So the only possible reason is the newly added fields to the sctp_chunk > >> structure. > >> > >> Is this expected? > > interesting , you didn't include the modification of the functions > > parts, right ? > = > Yes. > = > > you mean only this two line: > >> + unsigned long prsctp_param; > >> + int sent_count;ca; > > = > > caused the performance issue ? > = > Right. Note the test is done on my own Sandybridge desktop, I'll queue a job to run on the Ivybridge test box now. --===============8436431371481169028==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753797AbcHQHyA (ORCPT ); Wed, 17 Aug 2016 03:54:00 -0400 Received: from mga03.intel.com ([134.134.136.65]:51706 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbcHQHx7 (ORCPT ); Wed, 17 Aug 2016 03:53:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,529,1464678000"; d="scan'208";a="866789921" Date: Wed, 17 Aug 2016 15:53:57 +0800 From: Aaron Lu To: Xin Long Cc: kernel test robot , Stephen Rothwell , lkp@01.org, "David S. Miller" , LKML Subject: Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression Message-ID: <20160817075357.GA2558@aaronlu.sh.intel.com> References: <6e529b10-117d-8af0-66b3-2ccfb71acf2a@intel.com> <47965feb-3a4d-4e07-a9ed-86a3d58fb911@intel.com> <371c1f25-bc00-c36a-a7f5-fbe05cd58abc@intel.com> <20160817061405.GA5401@aaronlu.sh.intel.com> <20160817063719.GA5463@aaronlu.sh.intel.com> <375f06dd-8439-bba3-8b45-781e1e48dc9c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <375f06dd-8439-bba3-8b45-781e1e48dc9c@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2016 at 03:42:34PM +0800, Aaron Lu wrote: > On 08/17/2016 03:35 PM, Xin Long wrote: > >> include/net/sctp/structs.h | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h > >> index d8e464aacb20..932f2780d3a4 100644 > >> --- a/include/net/sctp/structs.h > >> +++ b/include/net/sctp/structs.h > >> @@ -602,6 +602,9 @@ struct sctp_chunk { > >> /* This needs to be recoverable for SCTP_SEND_FAILED events. */ > >> struct sctp_sndrcvinfo sinfo; > >> > >> + unsigned long prsctp_param; > >> + int sent_count; > >> + > >> /* Which association does this belong to? */ > >> struct sctp_association *asoc; > >> > >> -- > >> 2.5.5 > >> > >> Then the performance dropped to the same as the bisected commit > >> a6c2f792873a: > >> $ cat 4.7.0-rc6-01198-g98dd2532b14e/0/netperf.json > >> { > >> "netperf.Throughput_Mbps": [ > >> 754.494375 > >> ] > >> } > >> > >> I think this agrees with the perf data in that the newly added function > >> doesn't show up in the perf-profile but still, the performance drops. > >> So the only possible reason is the newly added fields to the sctp_chunk > >> structure. > >> > >> Is this expected? > > interesting , you didn't include the modification of the functions > > parts, right ? > > Yes. > > > you mean only this two line: > >> + unsigned long prsctp_param; > >> + int sent_count;ca; > > > > caused the performance issue ? > > Right. Note the test is done on my own Sandybridge desktop, I'll queue a job to run on the Ivybridge test box now.