From: Olaf Hering <olaf@aepfle.de>
To: Jordan_Hargrave@dell.com, xen-devel@lists.xen.org
Subject: [PATCH biosdevname]: handle dom0 on AMD systems
Date: Wed, 17 Aug 2016 12:30:50 +0200 [thread overview]
Message-ID: <20160817103050.GA10246@aepfle.de> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1615 bytes --]
Starting with xen-4.7 cpuid() will return with the hypervisor bit set
in a dom0 when running on an AMD system. As a result biosdevname
thinks it runs in a guest and does nothing. Detect a dom0 by looking
into xenfs. This works with classic xenlinux based kernels and with
pvops based kernels.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
src/bios_dev_name.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
--- a/src/bios_dev_name.c
+++ b/src/bios_dev_name.c
@@ -133,6 +133,31 @@ cpuid (u_int32_t eax, u_int32_t ecx)
}
/*
+ Starting with xen-4.7 cpuid will return with the hypervisor bit set
+ on AMD systems. This breaks biosdevname and network interface names.
+ Instead of relying on cpuid check for dom0 in xenfs.
+*/
+static int
+running_in_dom0(void)
+{
+ size_t len = 0;
+ char buf[16];
+ FILE *f = fopen("/proc/xen/capabilities", "r");
+
+ if (!f)
+ return 0;
+ memset(buf, 0, sizeof(buf));
+ len = fread(&buf, 1, sizeof(buf) - 1, f);
+ fclose(f);
+ while(len && --len && len < sizeof(buf)) {
+ if (buf[len] == '\n')
+ buf[len] = '\0';
+ }
+ len = !strcmp("control_d", buf);
+ return len;
+}
+
+/*
Algorithm suggested by:
http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1009458
*/
@@ -144,7 +171,11 @@ running_in_virtual_machine (void)
ecx = cpuid (eax, ecx);
if (ecx & 0x80000000U)
+ {
+ if (running_in_dom0())
+ return 0;
return 1;
+ }
return 0;
}
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-08-17 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 10:30 Olaf Hering [this message]
2016-08-17 11:51 ` [PATCH biosdevname]: handle dom0 on AMD systems Jan Beulich
2016-08-17 11:56 ` Andrew Cooper
2017-02-14 16:30 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817103050.GA10246@aepfle.de \
--to=olaf@aepfle.de \
--cc=Jordan_Hargrave@dell.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.