From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Minios-devel <minios-devel@lists.xenproject.org>,
Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [MINIOS PATCH 2/4] Introduce asm_macros.h
Date: Wed, 17 Aug 2016 15:03:44 +0100 [thread overview]
Message-ID: <20160817140344.GC20641@citrix.com> (raw)
In-Reply-To: <4325a69a-a313-ebba-6146-cb050984e0fc@citrix.com>
On Wed, Aug 17, 2016 at 03:01:07PM +0100, Andrew Cooper wrote:
> On 17/08/16 13:35, Wei Liu wrote:
> > diff --git a/include/asm_macros.h b/include/asm_macros.h
> > new file mode 100644
> > index 0000000..15dd377
> > --- /dev/null
> > +++ b/include/asm_macros.h
> > @@ -0,0 +1,36 @@
> > +/*
> > + * Macros for assembly files.
> > + */
> > +
> > +#ifndef _ASM_MACRO_H_
> > +#define _ASM_MACRO_H_
> > +
> > +#include <x86/asm_macros.h>
>
> This presumably should be <mini-os/arch_asm_macros.h>, and a stub file
> for ARM ?
>
Don't want to rearrange build system and directory hierarchy just yet.
Good point on ARM stub, though. I will add one for ARM.
Wei.
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-17 14:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 12:35 [MINIOS PATCH 0/4] x86: Use ELF notes and unfied linker script Wei Liu
2016-08-17 12:35 ` [MINIOS PATCH 1/4] gitignore: ignore vim swap file Wei Liu
2016-08-17 12:51 ` Samuel Thibault
2016-08-18 10:13 ` Wei Liu
2016-08-17 12:35 ` [MINIOS PATCH 2/4] Introduce asm_macros.h Wei Liu
2016-08-17 12:56 ` Samuel Thibault
2016-08-17 13:40 ` Wei Liu
2016-08-17 13:44 ` Wei Liu
2016-08-17 13:49 ` Andrew Cooper
2016-08-17 14:01 ` Andrew Cooper
2016-08-17 14:03 ` Wei Liu [this message]
2016-08-17 14:05 ` Wei Liu
2016-08-17 12:35 ` [MINIOS PATCH 3/4] x86: switch to use elfnote Wei Liu
2016-08-17 14:00 ` [Minios-devel] " Juergen Gross
2016-08-17 12:35 ` [MINIOS PATCH 4/4] x86: use unified linker script Wei Liu
2016-08-17 12:37 ` Wei Liu
2016-08-17 12:52 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817140344.GC20641@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.