From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org,
xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
samuel.thibault@ens-lyon.org
Subject: Re: [PATCH] mini-os: fix coverity issues in printf.c
Date: Wed, 17 Aug 2016 15:26:52 +0100 [thread overview]
Message-ID: <20160817142652.GE20641@citrix.com> (raw)
In-Reply-To: <db8c15e3-2a45-aa75-35d8-6e6a0ed0e3c8@suse.com>
On Wed, Aug 17, 2016 at 04:25:44PM +0200, Juergen Gross wrote:
> On 17/08/16 16:13, Wei Liu wrote:
> > On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote:
> >> Fix two issues discovered by coverity.
> >
> > I would update the commit message to make it contain more information.
> >
> > Fix two issues discovered by Coverity:
> >
> > 1. properl mark one switch case as fall-through
> > 2. unroll a loop that only executes once
> >
> > CID: 1369623
> > CID: 1019001
>
> Do you want me to resend or could you do that when committing?
>
I can do it.
I will wait for Samuel's ack.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-17 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 13:39 [PATCH] mini-os: fix coverity issues in printf.c Juergen Gross
2016-08-17 14:13 ` Wei Liu
2016-08-17 14:25 ` Juergen Gross
2016-08-17 14:26 ` Wei Liu [this message]
2016-08-20 12:49 ` Samuel Thibault
2016-08-20 12:50 ` Samuel Thibault
2016-08-22 9:41 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817142652.GE20641@citrix.com \
--to=wei.liu2@citrix.com \
--cc=jgross@suse.com \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.