From: Al Viro <viro@ZenIV.linux.org.uk>
To: Rob Clark <robdclark@gmail.com>
Cc: Vaishali Thakkar <vaishali.thakkar@oracle.com>,
David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
freedreno@lists.freedesktop.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: Use of copy_from_user in msm_gem_submit.c while holding a spin_lock
Date: Wed, 17 Aug 2016 20:31:20 +0100 [thread overview]
Message-ID: <20160817193120.GG2356@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAF6AEGv+0y14UXraXQkN+rRB-5-i=1Vr-0QtZ5DNzErXnqriug@mail.gmail.com>
On Wed, Aug 17, 2016 at 03:24:38PM -0400, Rob Clark wrote:
> hmm, looks like, at least on arm (not sure about arm64),
>
> #define __copy_from_user_inatomic __copy_from_user
>
> ie. copy_from_user() minus the access_ok() and memset in the
> !access_ok() path.. but maybe what I want is just the
> pagefault_disable() if that disables copy_from_user() being able to
> block..
On a bunch of platforms copy_from_user() starts with might_sleep(); again,
that'll spread to all of the pretty soon.
Right now those primitives are very badly out of sync; this will change,
but let's not add more PITA sources.
next prev parent reply other threads:[~2016-08-17 19:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 11:40 Use of copy_from_user in msm_gem_submit.c while holding a spin_lock Vaishali Thakkar
2016-08-17 11:40 ` Vaishali Thakkar
[not found] ` <57B44D2E.2030301-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-08-17 15:08 ` Rob Clark
2016-08-17 15:08 ` Rob Clark
2016-08-17 17:08 ` Al Viro
[not found] ` <20160817170827.GC2356-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2016-08-17 18:49 ` Rob Clark
2016-08-17 18:49 ` Rob Clark
[not found] ` <CAF6AEGtLVW-_PMhpb5YQX_vXfn5t=jH7Fe7R+1DbMaoWt6Cc1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-17 18:58 ` Rob Clark
2016-08-17 18:58 ` Rob Clark
2016-08-17 19:15 ` Al Viro
2016-08-17 19:15 ` Al Viro
2016-08-17 19:24 ` Rob Clark
2016-08-17 19:31 ` Al Viro [this message]
2016-08-18 8:31 ` Daniel Vetter
2016-08-18 8:31 ` Daniel Vetter
2016-08-17 21:29 ` Rob Clark
2016-08-17 21:29 ` Rob Clark
[not found] ` <CAF6AEGsJ0scrJp_4Udh2PTxwZq6_poRZuDQYHF6UayFb1htT5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-18 8:36 ` Daniel Vetter
2016-08-18 8:36 ` Daniel Vetter
2016-08-18 10:55 ` Rob Clark
2016-08-18 10:55 ` Rob Clark
2016-08-18 13:08 ` Daniel Vetter
2016-08-18 13:08 ` Daniel Vetter
2016-08-18 13:14 ` Rob Clark
2016-08-18 13:14 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817193120.GG2356@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=vaishali.thakkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.