From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v3 2/4] virtio: move SSE based Rx implementation to separate file Date: Thu, 18 Aug 2016 14:52:31 +0800 Message-ID: <20160818065231.GS30752@yliu-dev.sh.intel.com> References: <1467722966-2572-1-git-send-email-jerin.jacob@caviumnetworks.com> <1467722966-2572-3-git-send-email-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, thomas.monjalon@6wind.com, bruce.richardson@intel.com, jianbo.liu@linaro.org, huawei.xie@intel.com To: Jerin Jacob Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BEC5C5583 for ; Thu, 18 Aug 2016 08:43:41 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1467722966-2572-3-git-send-email-jerin.jacob@caviumnetworks.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 05, 2016 at 06:19:24PM +0530, Jerin Jacob wrote: > Split out SSE instruction based virtio simple Rx > implementation to a separate file > > Signed-off-by: Jerin Jacob Hi, I was about to apply this set. I then did some build test and found a weird issue: it breaks the build with clang (ubuntu 16.04). drivers/net/virtio/virtio_rxtx_simple_sse.c:130:2: error: cast from 'const void *' to 'void *' drops const qualifier [-Werror,-Wcast-qual] _mm_prefetch((const void *)rused, _MM_HINT_T0); ^ /usr/lib/llvm-3.8/bin/../lib/clang/3.8.0/include/xmmintrin.h:684:58: note: expanded from macro '_mm_prefetch' #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), 0, (sel))) ^ 1 error generated. Weird enough I don't see this issue before this commit: the error line is exactly the same before and after this commit. Another note is that _mm_prefetch() is actually with different prototype for gcc and clang. For gcc, we have: _mm_prefetch (const void *__P, enum _mm_hint __I) Any thoughts? --yliu