All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Jiayu Hu <jiayu.hu@intel.com>, dev@dpdk.org
Subject: Re: [PATCH 2/2] examples/vhost: support multiple socket files
Date: Thu, 18 Aug 2016 16:43:15 +0800	[thread overview]
Message-ID: <20160818084315.GX30752@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <f69564a2-3798-7d3c-ef3e-690d0f0fdfa2@redhat.com>

On Thu, Aug 18, 2016 at 10:27:55AM +0200, Maxime Coquelin wrote:
> 
> 
> On 08/16/2016 06:14 PM, Jiayu Hu wrote:
> >When examples/vhost runs in client mode, only one QEMU can be connected.
> >This is because that examples/vhost just supports one socket file. This
> >patch is to add multiple sockets support for examples/vhost.
> >
> >Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> >---
> > examples/vhost/main.c | 50 ++++++++++++++++++++++++++++++++++++++------------
> > 1 file changed, 38 insertions(+), 12 deletions(-)
> >
> >diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> >index a718577..9974f0b 100644
> >--- a/examples/vhost/main.c
> >+++ b/examples/vhost/main.c
> >@@ -136,8 +136,9 @@ static uint32_t burst_rx_delay_time = BURST_RX_WAIT_US;
> > /* Specify the number of retries on RX. */
> > static uint32_t burst_rx_retry_num = BURST_RX_RETRIES;
> >
> >-/* Socket file path. Can be set by user */
> >-static char socket_file[PATH_MAX] = "vhost-net";
> Default name being removed, you can drop my comment on patch 1. :)
> 
> >+/* Socket file paths. Can be set by user */
> >+static char *socket_files;
> >+int nb_sockets;
> Any reason not to make it static?

Right, it should be "static". Hmm, I missed it in review :(

	--yliu

  reply	other threads:[~2016-08-18  8:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 16:14 [PATCH 0/2] examples/vhost: rename a CLI option and support multiple socket files Jiayu Hu
2016-08-16 16:14 ` [PATCH 1/2] examples/vhost: rename dev-basename Jiayu Hu
2016-08-18  8:22   ` Maxime Coquelin
2016-08-18  8:35     ` Yuanhan Liu
2016-08-18  8:29       ` Maxime Coquelin
2016-08-20 10:10   ` Jiayu Hu
2016-08-23  6:01     ` Yuanhan Liu
2016-08-16 16:14 ` [PATCH 2/2] examples/vhost: support multiple socket files Jiayu Hu
2016-08-18  8:01   ` Yuanhan Liu
2016-08-18  8:27   ` Maxime Coquelin
2016-08-18  8:43     ` Yuanhan Liu [this message]
2016-08-20 10:11   ` Jiayu Hu
2016-08-23  6:05     ` Yuanhan Liu
2016-08-20 10:08 ` [PATCH 0/2] examples/vhost: rename a CLI option and " Jiayu Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160818084315.GX30752@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.