From: Ingo Molnar <mingo@kernel.org>
To: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, bp@suse.de
Subject: Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing
Date: Thu, 18 Aug 2016 11:47:30 +0200 [thread overview]
Message-ID: <20160818094730.GA1967@gmail.com> (raw)
In-Reply-To: <1471416172-9463-1-git-send-email-weijg.fnst@cn.fujitsu.com>
* Wei Jiangang <weijg.fnst@cn.fujitsu.com> wrote:
> Check the boot APIC ID firstly,
> and then setup the default routing of APIC looks better.
>
> And move default_setup_apic_routing() close to apic_bsp_setup(),
> which staying in step with the codes in APIC_init_uniprocessor().
>
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
> arch/x86/kernel/smpboot.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
If it's not a bug then please clearly note so in the changelog and
explain why the change results in better code.
If it's fixing a bug/misfeature then please fix the changelog to
conform to the standard changelog style:
- first describe the symptoms of the bug - how does a user notice?
- then describe how the code behaves today and how that is causing the bug
- and then only describe how it's fixed.
Thanks,
Ingo
next prev parent reply other threads:[~2016-08-18 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 6:42 [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing Wei Jiangang
2016-08-17 6:42 ` [PATCH 2/2] x86/apic: Update comment about disabling processor focus Wei Jiangang
2016-08-18 9:47 ` Ingo Molnar [this message]
2016-08-18 10:15 ` [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing Wei, Jiangang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818094730.GA1967@gmail.com \
--to=mingo@kernel.org \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=weijg.fnst@cn.fujitsu.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.