From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
Simon Horman <horms@verge.net.au>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support
Date: Thu, 18 Aug 2016 20:41:40 +0200 [thread overview]
Message-ID: <20160818184139.GA1472@tetsubishi> (raw)
In-Reply-To: <CAMuHMdV31WewDgV8c6gGdssSvXO4sX2hCcV3w6SMxD-eyUc9Cw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
> I'll try to remove it. Note that sh73a0-kzm9g.dts also uses broken-cd,
> without ill effects.
This one does have a seperate card-detect-irq (which is not populated
for sdhi2) while the other one only has one, generic irq. That's at
least a difference.
We could try to see if there are unexpected card-detect events by
instrumenting mmc_detect_change() in tmio_mmc_pio.c, but my feeling is
that the card_busy change you reverted is only making something visible
which went wrong before the change, also.
So, it might be worth to protect the whole voltage_switch and card_busy
functionality with TMIO_MMC_MIN_RCAR2?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-19 2:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 15:44 [PATCH v2 0/9] r8a7790: add UHS-I (SDR50) support to Lager Wolfram Sang
2016-04-01 15:44 ` [PATCH v2 1/9] mmc: tmio, sh_mobile_sdhi: Pass tmio_mmc_host ptr to clk_{enable,disable} ops Wolfram Sang
2016-04-01 15:44 ` [PATCH v2 2/9] mmc: tmio, sh_mobile_sdhi: Add support for variable input clock frequency Wolfram Sang
2016-04-12 12:55 ` Geert Uytterhoeven
2016-04-12 16:19 ` Ben Hutchings
2016-04-15 20:28 ` Wolfram Sang
2016-04-15 20:41 ` Wolfram Sang
2016-04-17 12:49 ` Wolfram Sang
2016-04-18 7:33 ` Geert Uytterhoeven
2016-04-26 10:18 ` Geert Uytterhoeven
2016-04-26 17:00 ` Wolfram Sang
2016-04-01 15:44 ` [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support Wolfram Sang
2016-08-16 18:05 ` Geert Uytterhoeven
2016-08-16 19:55 ` Wolfram Sang
2016-08-16 20:21 ` Geert Uytterhoeven
2016-08-17 19:08 ` Wolfram Sang
2016-08-17 20:17 ` Geert Uytterhoeven
2016-08-18 18:41 ` Wolfram Sang [this message]
2016-08-23 12:34 ` Geert Uytterhoeven
2016-04-01 15:44 ` [PATCH v2 4/9] mmc: tmio: always start clock after frequency calculation Wolfram Sang
2016-04-01 15:44 ` [PATCH v2 5/9] mmc: tmio: stop clock when 0Hz is requested Wolfram Sang
2016-04-01 15:44 ` [PATCH v2 6/9] mmc: host: add note that set_ios needs to handle 0Hz properly Wolfram Sang
2016-04-01 15:44 ` [PATCH v2 7/9] mmc: sh_mobile_sdhi: Add UHS-I mode support Wolfram Sang
2016-04-04 15:04 ` Ulf Hansson
2016-04-04 15:17 ` Wolfram Sang
2016-04-04 15:52 ` Ulf Hansson
2016-04-04 15:56 ` Wolfram Sang
2016-04-01 15:44 ` [PATCH v2 8/9] ARM: shmobile: r8a7790: Set maximum frequencies for SDHI clocks Wolfram Sang
2016-04-01 15:44 ` [PATCH v2 9/9] ARM: shmobile: r8a7790: lager: Enable UHS-I SDR-50 Wolfram Sang
2016-04-06 0:56 ` [v2,9/9] " Simon Horman
2016-04-06 6:38 ` Geert Uytterhoeven
2016-04-06 7:13 ` Simon Horman
2016-04-04 15:08 ` [PATCH v2 0/9] r8a7790: add UHS-I (SDR50) support to Lager Ulf Hansson
2016-04-04 15:21 ` Wolfram Sang
2016-04-05 11:12 ` Ulf Hansson
2016-04-05 11:19 ` Wolfram Sang
2016-04-06 0:56 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818184139.GA1472@tetsubishi \
--to=wsa@the-dreams.de \
--cc=ben.hutchings@codethink.co.uk \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.