From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Fri, 19 Aug 2016 07:41:10 +0000 Subject: Re: [PATCH 0/2] GPU-DRM-Savage: Fine-tuning for savage_bci_cmdbuf() Message-Id: <20160819074110.GT6232@phenom.ffwll.local> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <77052ac1-1933-49af-3ad8-6e0eecc1aafe@users.sourceforge.net> In-Reply-To: <77052ac1-1933-49af-3ad8-6e0eecc1aafe@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, LKML , "dri-devel@lists.freedesktop.org" , Julia Lawall On Thu, Aug 18, 2016 at 09:42:33PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 18 Aug 2016 21:38:37 +0200 > > A few update suggestions were taken into account > from static source code analysis. savage is one of the dri1 legacy drivers, imo not really worth it to spend time on them. otoh no one will notice any breakage either ;-) I guess I'll apply. -Daniel > > Markus Elfring (2): > Use memdup_user() rather than duplicating its implementation > Less function calls after error detection > > drivers/gpu/drm/savage/savage_state.c | 42 +++++++++++++++-------------------- > 1 file changed, 18 insertions(+), 24 deletions(-) > > -- > 2.9.3 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 0/2] GPU-DRM-Savage: Fine-tuning for savage_bci_cmdbuf() Date: Fri, 19 Aug 2016 09:41:10 +0200 Message-ID: <20160819074110.GT6232@phenom.ffwll.local> References: <566ABCD9.1060404@users.sourceforge.net> <77052ac1-1933-49af-3ad8-6e0eecc1aafe@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F3F26E025 for ; Fri, 19 Aug 2016 07:41:44 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id q128so2353759wma.1 for ; Fri, 19 Aug 2016 00:41:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <77052ac1-1933-49af-3ad8-6e0eecc1aafe@users.sourceforge.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, LKML , "dri-devel@lists.freedesktop.org" , Julia Lawall List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBdWcgMTgsIDIwMTYgYXQgMDk6NDI6MzNQTSArMDIwMCwgU0YgTWFya3VzIEVsZnJp bmcgd3JvdGU6Cj4gRnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9y Z2UubmV0Pgo+IERhdGU6IFRodSwgMTggQXVnIDIwMTYgMjE6Mzg6MzcgKzAyMDAKPiAKPiBBIGZl dyB1cGRhdGUgc3VnZ2VzdGlvbnMgd2VyZSB0YWtlbiBpbnRvIGFjY291bnQKPiBmcm9tIHN0YXRp YyBzb3VyY2UgY29kZSBhbmFseXNpcy4KCnNhdmFnZSBpcyBvbmUgb2YgdGhlIGRyaTEgbGVnYWN5 IGRyaXZlcnMsIGltbyBub3QgcmVhbGx5IHdvcnRoIGl0IHRvIHNwZW5kCnRpbWUgb24gdGhlbS4g b3RvaCBubyBvbmUgd2lsbCBub3RpY2UgYW55IGJyZWFrYWdlIGVpdGhlciA7LSkKCkkgZ3Vlc3Mg SSdsbCBhcHBseS4KLURhbmllbAoKPiAKPiBNYXJrdXMgRWxmcmluZyAoMik6Cj4gICBVc2UgbWVt ZHVwX3VzZXIoKSByYXRoZXIgdGhhbiBkdXBsaWNhdGluZyBpdHMgaW1wbGVtZW50YXRpb24KPiAg IExlc3MgZnVuY3Rpb24gY2FsbHMgYWZ0ZXIgZXJyb3IgZGV0ZWN0aW9uCj4gCj4gIGRyaXZlcnMv Z3B1L2RybS9zYXZhZ2Uvc2F2YWdlX3N0YXRlLmMgfCA0MiArKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMjQgZGVs ZXRpb25zKC0pCj4gCj4gLS0gCj4gMi45LjMKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJl IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755289AbcHSHlr (ORCPT ); Fri, 19 Aug 2016 03:41:47 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34948 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbcHSHlp (ORCPT ); Fri, 19 Aug 2016 03:41:45 -0400 Date: Fri, 19 Aug 2016 09:41:10 +0200 From: Daniel Vetter To: SF Markus Elfring Cc: "dri-devel@lists.freedesktop.org" , Daniel Vetter , David Airlie , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 0/2] GPU-DRM-Savage: Fine-tuning for savage_bci_cmdbuf() Message-ID: <20160819074110.GT6232@phenom.ffwll.local> Mail-Followup-To: SF Markus Elfring , "dri-devel@lists.freedesktop.org" , David Airlie , LKML , kernel-janitors@vger.kernel.org, Julia Lawall References: <566ABCD9.1060404@users.sourceforge.net> <77052ac1-1933-49af-3ad8-6e0eecc1aafe@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77052ac1-1933-49af-3ad8-6e0eecc1aafe@users.sourceforge.net> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2016 at 09:42:33PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 18 Aug 2016 21:38:37 +0200 > > A few update suggestions were taken into account > from static source code analysis. savage is one of the dri1 legacy drivers, imo not really worth it to spend time on them. otoh no one will notice any breakage either ;-) I guess I'll apply. -Daniel > > Markus Elfring (2): > Use memdup_user() rather than duplicating its implementation > Less function calls after error detection > > drivers/gpu/drm/savage/savage_state.c | 42 +++++++++++++++-------------------- > 1 file changed, 18 insertions(+), 24 deletions(-) > > -- > 2.9.3 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch