From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baevd-0007Sq-1Y for qemu-devel@nongnu.org; Fri, 19 Aug 2016 04:13:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baevY-0004Oc-Nk for qemu-devel@nongnu.org; Fri, 19 Aug 2016 04:13:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baevY-0004O2-Hv for qemu-devel@nongnu.org; Fri, 19 Aug 2016 04:13:20 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 050E54E4C5 for ; Fri, 19 Aug 2016 08:13:20 +0000 (UTC) Date: Fri, 19 Aug 2016 09:13:15 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160819081315.GA2004@work-vm> References: <20160819065037.GA32302@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160819065037.GA32302@pxdev.xzpeter.org> Subject: Re: [Qemu-devel] Question with migrate_set_speed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: QEMU Devel Mailing List , "Daniel P. Berrange" , quintela@redhat.com, Amit Shah * Peter Xu (peterx@redhat.com) wrote: > Hi, > > I am playing with live migration and got one question about live > migration set_speed. > > Now we can use migrate_set_speed to configure the threshold during > migration (it should be only used for precopy, so let's assume the > migration is a precopy case). However I feel like this single > parameter cannot describe the process very clearly. > > The problem is, we use this "speed" value as both: > > 1. transfer threshold, to make sure migration stream is relatively > constant and under control > > 2. value to estimate "when we should stop the vm and start counting > downtime" > > For (1), we want a customized value that best suites our network > environment. E.g., if we have other critical network payloads, we can > set this to a very small number, so the migration stream will be very > small. > > For (2), it should be nothing else but possibly the network bandwidth > that the system can provide on the migration link. Actually, that's what QEMU does; the migrate_set_speed is really only used for (1) directly. (2) actually comes from a measured bandwidth multiplied by the 'migrate_set_downtime' figure. (See around line 1800ish i migration/migration.c inside the if (current_time >= initial+time + BUFFER_DELAY) if ). > We can set_speed to a very small value to avoid disturbing other > network services, that's good. However using the same value to > estimate "when to stop" seems odd, since this value can be far away > from the real network speed (when we are transfering the last bits in > precopy, we should be using the max network speed all the time, which > actually is not affected by the threshold value). > > IMHO, it'll be clearer if these are two different tunables, e.g., not > sure whether it'll be cool to add another tunable "set_speed_max", to > configure the speed for the (2) case (when vm is stopped on source). > If so, it'll be clearer, and also bring another benefit: users can > have full control of the last migration phase as well, in case they > don't want to suffer from a network fluctuation for each ends of > migration. > > Still haven't thought further. Just throw this question out. I don't think people are very good at setting the two tunables we already have! Dave > > Thanks, > > -- peterx -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK