From: Han Xu <xhnjupt@gmail.com>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: computersforpeace@gmail.com, dwmw2@infradead.org, han.xu@nxp.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: constify fsl_qspi_devtype_data
Date: Sat, 20 Aug 2016 02:01:31 +0800 [thread overview]
Message-ID: <20160819180131.GA729@shlinux2> (raw)
In-Reply-To: <1471352198-7327-1-git-send-email-clabbe.montjoie@gmail.com>
On Tue, Aug 16, 2016 at 02:56:38PM +0200, LABBE Corentin wrote:
> All fsl_qspi_devtype_data structures are never modified.
> This patch constify them.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
> drivers/mtd/spi-nor/fsl-quadspi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 5c82e4e..b4d8953 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -224,7 +224,7 @@ struct fsl_qspi_devtype_data {
> int driver_data;
> };
>
> -static struct fsl_qspi_devtype_data vybrid_data = {
> +static const struct fsl_qspi_devtype_data vybrid_data = {
> .devtype = FSL_QUADSPI_VYBRID,
> .rxfifo = 128,
> .txfifo = 64,
> @@ -232,7 +232,7 @@ static struct fsl_qspi_devtype_data vybrid_data = {
> .driver_data = QUADSPI_QUIRK_SWAP_ENDIAN,
> };
>
> -static struct fsl_qspi_devtype_data imx6sx_data = {
> +static const struct fsl_qspi_devtype_data imx6sx_data = {
> .devtype = FSL_QUADSPI_IMX6SX,
> .rxfifo = 128,
> .txfifo = 512,
> @@ -241,7 +241,7 @@ static struct fsl_qspi_devtype_data imx6sx_data = {
> | QUADSPI_QUIRK_TKT245618,
> };
>
> -static struct fsl_qspi_devtype_data imx7d_data = {
> +static const struct fsl_qspi_devtype_data imx7d_data = {
> .devtype = FSL_QUADSPI_IMX7D,
> .rxfifo = 512,
> .txfifo = 512,
> @@ -250,7 +250,7 @@ static struct fsl_qspi_devtype_data imx7d_data = {
> | QUADSPI_QUIRK_4X_INT_CLK,
> };
>
> -static struct fsl_qspi_devtype_data imx6ul_data = {
> +static const struct fsl_qspi_devtype_data imx6ul_data = {
> .devtype = FSL_QUADSPI_IMX6UL,
> .rxfifo = 128,
> .txfifo = 512,
> --
> 2.7.3
>
Acked-by: Han Xu <han.xu@nxp.com>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2016-08-19 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 12:56 [PATCH] mtd: spi-nor: constify fsl_qspi_devtype_data LABBE Corentin
2016-08-19 18:01 ` Han Xu [this message]
2016-11-28 8:29 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819180131.GA729@shlinux2 \
--to=xhnjupt@gmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.