From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: keescook@chromium.org, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, pebolle@tiscali.nl,
ziegler@cs.fau.de
Subject: Re: [PATCH] lib/Kconfig.debug: fix typo in select statement
Date: Sat, 20 Aug 2016 11:20:13 -0700 [thread overview]
Message-ID: <20160820182013.GN3482@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160820101610.53184-1-valentinrothberg@gmail.com>
On Sat, Aug 20, 2016 at 12:16:10PM +0200, Valentin Rothberg wrote:
> Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption")
> added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_
> prefix is only used in Make and C(PP) syntax. Remove the CONFIG_ prefix
> to correctly select the Kconfig option DEBUG_LIST.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
Well, color me blind!
Good catch, queued for review and testing.
Kees, Steve, Rik, any objections?
Thanx, Paul
> ---
> I detected the issue with scripts/checkkconfigsymbols.py
>
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 5dea4d0a5a07..c2bbaae13d04 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS
>
> config BUG_ON_DATA_CORRUPTION
> bool "Trigger a BUG when data corruption is detected"
> - select CONFIG_DEBUG_LIST
> + select DEBUG_LIST
> help
> Select this option if the kernel should BUG when it encounters
> data corruption in kernel memory structures when they get checked
> --
> 2.9.3
>
next prev parent reply other threads:[~2016-08-20 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-20 10:16 [PATCH] lib/Kconfig.debug: fix typo in select statement Valentin Rothberg
2016-08-20 18:20 ` Paul E. McKenney [this message]
2016-08-21 3:24 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160820182013.GN3482@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rostedt@goodmis.org \
--cc=valentinrothberg@gmail.com \
--cc=ziegler@cs.fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.