From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Sun, 21 Aug 2016 15:55:51 +0000 Subject: Re: [PATCH 1/2] staging: dgnc: change a parameter from tty_struct to Message-Id: <20160821155551.GA3303@kroah.com> List-Id: References: <20160819010452.GA8009@SEL-JYOUN-D1> In-Reply-To: <20160819010452.GA8009@SEL-JYOUN-D1> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daeseok Youn Cc: devel@driverdev.osuosl.org, lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Aug 19, 2016 at 10:04:52AM +0900, Daeseok Youn wrote: > The dgnc_maxcps_room() function must be called only for print device. > The if-statement for checking print device checks before calling > maxcps_room() and also this function doesn't need to have any > data except channel_t. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_tty.c | 18 +++++------------- > 1 file changed, 5 insertions(+), 13 deletions(-) Your subject line doesn't make much sense, does it? :( Please fix up and resend. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932216AbcHUV2S (ORCPT ); Sun, 21 Aug 2016 17:28:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34333 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753418AbcHUV2I (ORCPT ); Sun, 21 Aug 2016 17:28:08 -0400 Date: Sun, 21 Aug 2016 17:55:51 +0200 From: Greg KH To: Daeseok Youn Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: dgnc: change a parameter from tty_struct to Message-ID: <20160821155551.GA3303@kroah.com> References: <20160819010452.GA8009@SEL-JYOUN-D1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160819010452.GA8009@SEL-JYOUN-D1> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2016 at 10:04:52AM +0900, Daeseok Youn wrote: > The dgnc_maxcps_room() function must be called only for print device. > The if-statement for checking print device checks before calling > maxcps_room() and also this function doesn't need to have any > data except channel_t. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_tty.c | 18 +++++------------- > 1 file changed, 5 insertions(+), 13 deletions(-) Your subject line doesn't make much sense, does it? :( Please fix up and resend. thanks, greg k-h