From: Joerg Roedel <jroedel@suse.de>
To: Fabian Frederick <fabf@skynet.be>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] iommu/amd: remove AMD_IOMMU_STATS
Date: Mon, 22 Aug 2016 12:50:32 +0200 [thread overview]
Message-ID: <20160822105032.GG2547@suse.de> (raw)
In-Reply-To: <1471038887-13199-1-git-send-email-fabf@skynet.be>
On Fri, Aug 12, 2016 at 11:54:47PM +0200, Fabian Frederick wrote:
> Commit e85e8f69cedb
> ("iommu/amd: Remove statistics code")
> removed that config.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> arch/x86/configs/x86_64_defconfig | 1 -
> drivers/iommu/amd_iommu_proto.h | 4 ----
> 2 files changed, 5 deletions(-)
>
> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
> index d28bdab..7ef4a09 100644
> --- a/arch/x86/configs/x86_64_defconfig
> +++ b/arch/x86/configs/x86_64_defconfig
> @@ -255,7 +255,6 @@ CONFIG_RTC_CLASS=y
> CONFIG_DMADEVICES=y
> CONFIG_EEEPC_LAPTOP=y
> CONFIG_AMD_IOMMU=y
> -CONFIG_AMD_IOMMU_STATS=y
> CONFIG_INTEL_IOMMU=y
> # CONFIG_INTEL_IOMMU_DEFAULT_ON is not set
> CONFIG_EFI_VARS=y
> diff --git a/drivers/iommu/amd_iommu_proto.h b/drivers/iommu/amd_iommu_proto.h
> index 0bd9eb3..697bccc 100644
> --- a/drivers/iommu/amd_iommu_proto.h
> +++ b/drivers/iommu/amd_iommu_proto.h
> @@ -78,12 +78,8 @@ static inline int amd_iommu_create_irq_domain(struct amd_iommu *iommu)
> extern int amd_iommu_complete_ppr(struct pci_dev *pdev, int pasid,
> int status, int tag);
>
> -#ifndef CONFIG_AMD_IOMMU_STATS
> -
> static inline void amd_iommu_stats_init(void) { }
That function can be removed too, while you are at it. Thanks for
cleaning that up.
Joerg
prev parent reply other threads:[~2016-08-22 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 21:54 [PATCH 1/1 linux-next] iommu/amd: remove AMD_IOMMU_STATS Fabian Frederick
2016-08-22 10:50 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822105032.GG2547@suse.de \
--to=jroedel@suse.de \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.